Optimize #83
Closed
Optimize #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* read file by line until match * only read files once per check * prefer include over match replacing readlines.grep happens to fix voxpupuli#63
zilchms
approved these changes
Jan 26, 2024
bastelfreak
approved these changes
Jan 29, 2024
|
@h0tw1r3 thanks a lot for the PR! Code looks really good. One nitpick: I'm not sure how we can give those changes a proper PR title. Do you have an idea? Otherwise could you split those commits up into 4 PRs maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing readlines.grep also happens to fix #63.
Tried to create a test, but I was unable to reproduce outside of a production environment.