Add purging to $config_path dir #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add purging to $config_path dir to remove floating ipset config files
|
I am not a user of the module so I could be wrong, I feel that this is a breaking change (e.g. if the user has local files managed outside puppet in this directory)? Also, maybe we can make this an option the user opt-in to purge all files not managed by Puppet? We have similar things e.g. in the puppetlabs-apache module where unmanaged config / Virtual Hosts are purged depending on some parameters. |
Purging disabled by default to make sure this is not a breaking change
|
Added a feature flag to toggle the purging which is disabled by default, this should mitigate the possible breaking change factor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add purging to $config_path dir to remove floating ipset config files