Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement content param for file resource #223

Closed
wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Member

this is a PR for
issue 222, I tested it with puppet 3.8.1 on centos7, it is working fine.

You can now specify a content or a source param to the logstash:patternfile resource.

this is a PR for
[issue](voxpupuli#222), I tested
it with puppet 3.8.1 on centos7, it is working fine.
@bastelfreak
Copy link
Member Author

signed the CLA

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@ninaspitfire
Copy link
Contributor

For Logstash 5.X, the module has been heavily rewritten. As a result, all outstanding pull requests (some of which are very old) are unfortunately suffering from severe merge conflicts, and many of them are probably no longer needed.

With the release of the new version, the time has come to close out all the pull requests that have, in all honesty, been neglected. Starting with a clean slate will help us focus on new pull requests that come in against the new code base and the much-improved acceptance test suite.

I apologise for the lost work that is represented in this pull request and will strive, as the current maintainer, to not let pull requests get into a state like this in future.

@karmi
Copy link

karmi commented Dec 19, 2016

Hi @bastelfreak, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants