Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH323) Better parameterization of root user/group from #279 #324

Merged
merged 1 commit into from
Jan 6, 2017

Conversation

rnelson0
Copy link
Member

@rnelson0 rnelson0 commented Jan 6, 2017

Fixes #323

The parameters $root_user and $root_group were added in #279. To do so, the main class r10k was required, rather than using the values from r10k::params, which created a conflict when using some subclasses without the main r10k class; specifically when replacing it with pe_r10k. This adjustment allows fully independent usage of r10k::mcollective and r10k::webhook again. It may require adjustment of the class parameters/hiera values, however, since the value in both classes is pulled from r10k::params. Heads up @buzzdeee and other users who may have overridden that value.

@rnelson0 rnelson0 added the needs-work not ready to merge just yet label Jan 6, 2017
@rnelson0 rnelson0 merged commit 2e86eae into master Jan 6, 2017
@rnelson0 rnelson0 deleted the no_require branch January 6, 2017 16:59
@rnelson0 rnelson0 removed the needs-work not ready to merge just yet label Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants