Add generate_types to Mcollective R10K plugin #458
Conversation
Check manifests/params.pp for detail
exec will replace current process with the shell sub-process instead of spawning separate new process all executable commands are passed to run_command, there is no much point to fork the process before exec
the usage is mco r10k generate_types ENVIRONMENT
|
Have you tried to run it under non-root account? 'generate types' will not work properly unless passed additional options, i.e.: |
|
is that because the user doesn't have permission to read puppet.conf? |
|
That's a strange puppet's feature. You can check under unprivileged account: They all will be in $HOME/.puppetlabs |
|
yes, so I guess you could put the additional options to the puppet.conf of unprivileged users? Of course we can change the code to allow additional parameters, but the additional options are global options not only related to |
|
Dear @stanleyz, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @stanleyz, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Is this still being looked into rebasing and merging? |
|
No, sorry, I've been busy on something else.
…On Wed, Sep 16, 2020 at 3:39 AM jakegroves ***@***.***> wrote:
Is this still being looked into rebasing and merging?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#458 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOZBMHUT4N5BQNMJU7T3SDSF6DBDANCNFSM4GEIXABA>
.
|
|
can we transfer what's here (also) into a bolt task? |
|
I think we can close this now because r10k supports the type generation. |
This MR includes the following: