Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for restoring redis backups #33

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Add support for restoring redis backups #33

merged 3 commits into from
Jul 26, 2023

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Jul 4, 2023 •
edited
Loading

Summary

  • This PR adds a new composite function to configure restores for redis.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee force-pushed the feature/redis_restore branch 3 times, most recently from 6d967b1 to 3942ae6 Compare July 18, 2023 08:28
@TheBigLee TheBigLee added enhancement New feature or request go Pull requests that update Go code labels Jul 18, 2023
@TheBigLee TheBigLee force-pushed the feature/redis_restore branch 2 times, most recently from b623cf3 to 7fba71b Compare July 18, 2023 15:06
@TheBigLee TheBigLee marked this pull request as ready for review July 18, 2023 15:10
glrf
glrf approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

crds/vshn.appcat.vshn.io_vshnredis.yaml Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnredis/restore.go Outdated Show resolved Hide resolved
zugao
zugao previously requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to check.

crds/vshn.appcat.vshn.io_vshnredis.yaml Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnredis/script/prepRestore.sh Show resolved Hide resolved
pkg/comp-functions/functions/vshnredis/script/prepRestore.sh Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnredis/script/cleanupRestore.sh Outdated Show resolved Hide resolved
@TheBigLee TheBigLee force-pushed the feature/redis_restore branch 2 times, most recently from c0bc3f5 to 8e8c8a9 Compare July 18, 2023 15:59
@TheBigLee TheBigLee requested review from glrf and zugao July 19, 2023 13:15
@TheBigLee
Make scripts more robust
1de69dc 
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee TheBigLee requested a review from glrf July 26, 2023 14:09
Kidswiss
Kidswiss requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The completed event should probably not be a warning :)

But it's a nice touch, we should also document this, so customers know if/when a restore failed or completed.

glrf
glrf approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Emitting events is a great idea.

However, please make sure that you add the permissions to create events in the component. I think the current roles can't.

@TheBigLee
Copy link
Member Author

The completed event should probably not be a warning :)

But it's a nice touch, we should also document this, so customers know if/when a restore failed or completed.

Fixed

@TheBigLee TheBigLee requested a review from Kidswiss July 26, 2023 15:27
@TheBigLee TheBigLee requested review from zugao and removed request for zugao July 26, 2023 15:28
@TheBigLee TheBigLee dismissed zugao’s stale review July 26, 2023 15:29

Currently on holidays

@TheBigLee TheBigLee merged commit 0e022d8 into master Jul 26, 2023
3 checks passed
@TheBigLee TheBigLee deleted the feature/redis_restore branch July 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao left review comments

@glrf glrf glrf approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheBigLee @Kidswiss @glrf @zugao