Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test race condition #42

Closed
wants to merge 1 commit into from
Closed

Fix test race condition #42

wants to merge 1 commit into from

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented Jul 18, 2023

Summary

  • This small change should resolve the race condition in GivenMaintenanceTooLong_ThenExpectNoRepack test

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@zugao zugao added the bug Something isn't working label Jul 18, 2023
@Kidswiss
Copy link
Contributor

There's a typo in the title.

Could you also please elaborate how this should fix the race condition? Did it run into a timeout because it waited too long?

@zugao zugao changed the title Fix test reace condition Fix test race condition Jul 19, 2023
@zugao
Copy link
Collaborator Author

zugao commented Jul 19, 2023

There's a typo in the title.

Could you also please elaborate how this should fix the race condition? Did it run into a timeout because it waited too long?

The problem can occur only in a test. Apparently the updates to the fake client are so fast that 1 second is too much for the test to go into timeout therefore I set it to a millisecond which will trigger right away the timeout and the test will always be green.

@zugao
Copy link
Collaborator Author

zugao commented Jul 19, 2023

This issue was fixed already in another MR, closing.

@zugao zugao closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants