Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upgrading redis to newer versions #49

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Jul 28, 2023

Summary

Currently we do not allow any changes to the redis version after creation. With this PR we allow to change the version as long as it is a higher minor/major version.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@glrf glrf added the enhancement New feature or request label Jul 28, 2023
@glrf glrf self-assigned this Jul 28, 2023
@glrf glrf force-pushed the feat/allow-redis-upgrade branch from 5718571 to 8eb2eea Compare July 28, 2023 13:46
@glrf glrf marked this pull request as ready for review July 28, 2023 14:41
@glrf glrf requested review from TheBigLee and wejdross July 28, 2023 14:41
@TheBigLee TheBigLee self-requested a review July 31, 2023 09:05
Copy link
Member

@wejdross wejdross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TheBigLee TheBigLee merged commit 2c3cd69 into master Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants