Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Central Control Plane and Exoscale OSB API #122

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Central Control Plane and Exoscale OSB API #122

merged 1 commit into from
Dec 6, 2024

Conversation

tobru
Copy link
Member

@tobru tobru commented Nov 11, 2024 •
edited
Loading

Summary

This document describes how we integrate the VSHN Application Catalog into the Exoscale Marketplace and how the new Central Control Plane works.

@tobru tobru added the enhancement New feature or request label Nov 11, 2024
simu
simu reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious issues in the Exoscale OSB integration, but I'm not very familiar with that part.

docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Show resolved Hide resolved
@tobru tobru changed the title OpenServiceBroker for Exoscale integration Central Control Plane and Exoscale OSB API Dec 6, 2024
@tobru tobru marked this pull request as ready for review December 6, 2024 08:35
@tobru tobru requested a review from Kidswiss December 6, 2024 08:38
Kidswiss
Kidswiss requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more things. But all in all it should be good.

We'll most definitely find the rest of the issues during implementation.

docs/modules/ROOT/pages/reference/exoscale-osbapi.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/reference/arch-control-plane.adoc Outdated Show resolved Hide resolved
@tobru tobru requested a review from Kidswiss December 6, 2024 10:44
Kidswiss
Kidswiss approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobru tobru merged commit ba53861 into master Dec 6, 2024
1 check passed
@tobru tobru deleted the exoscale-osb branch December 6, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu left review comments

@Kidswiss Kidswiss Kidswiss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobru @simu @Kidswiss