Adding necessary field names to handle external IPs in connection secret #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wejdross
force-pushed
the
add/PSQLServiceType
branch
from
ecec7f8
to
ee78fa9
Compare
Kidswiss
requested changes
Jul 26, 2023
Kidswiss
reviewed
Jul 27, 2023
component/vshn_postgres.jsonnet
Outdated
| @@ -403,6 +413,8 @@ local sgCluster = { | |||
|
|
|||
| comp.FromCompositeFieldPath('spec.parameters.backup.schedule', 'spec.forProvider.manifest.spec.configurations.backups[0].cronSchedule'), | |||
| comp.FromCompositeFieldPath('spec.parameters.backup.retention', 'spec.forProvider.manifest.spec.configurations.backups[0].retention'), | |||
| comp.FromCompositeFieldPath('spec.parameters.network.serviceType', 'spec.forProvider.manifest.spec.postgresServices.primary.type'), | |||
There was a problem hiding this comment.
I just saw, that you also have logic in the composition function. Please do these patches there as well. It's confusing if the logic is spread over the composition function and the legacy P+T compostion.
Kidswiss
reviewed
Jul 27, 2023
tests/golden/vshn/appcat/appcat/21_composition_vshn_postgres.yaml
Outdated
Show resolved
Hide resolved
wejdross
force-pushed
the
add/PSQLServiceType
branch
from
101f29e
to
19f8b62
Compare
|
@Kidswiss please re-review component-appcat as well |
Kidswiss
requested changes
Aug 8, 2023
| @@ -38,6 +38,7 @@ parameters: | |||
| services: | |||
| vshn: | |||
| enabled: true | |||
| externalDatabaseConnectionsEnabled: true | |||
There was a problem hiding this comment.
Can you add this parameter to the default as well? But set it to false, as we can only use it on specific clusters.
Otherwise the compilation will probably fail for the remaining clusters, as there is no field with that name available.
Kidswiss
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is strictly connected with: vshn/appcat#46
I need to add fields to connection secret so crossplane can write to them
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.