Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud billing query #521

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix cloud billing query #521

merged 1 commit into from
Oct 29, 2024
+37 −37

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Oct 29, 2024

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@zugao zugao added the patch label Oct 29, 2024
@zugao zugao requested review from Kidswiss, a team, TheBigLee and wejdross and removed request for a team October 29, 2024 08:22
Kidswiss
Kidswiss approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run that query against an actualy prometheus or mimir instance to verify?

@zugao
Copy link
Contributor Author

zugao commented Oct 29, 2024

Did you run that query against an actualy prometheus or mimir instance to verify?

Both. The right answer is Mimir but it doesn't matter the query was syntactically wrong.

@zugao zugao merged commit d113c15 into master Oct 29, 2024
28 checks passed
@zugao zugao deleted the fix-billing-cloud-query branch October 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zugao @Kidswiss