Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure backup retention is properly defaulted #575

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Dec 12, 2024

Summary

Due to a limitation in the kubebuilder framework, we need a hack to ensure that objects actually get the specified defaults.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Link: vshn/appcat#284

@Kidswiss Kidswiss added the patch label Dec 12, 2024
@Kidswiss Kidswiss changed the title PR for appcat on fix/default_backup_retetion Make sure backup retention is properly defaulted Dec 12, 2024
@Kidswiss Kidswiss requested review from a team, Kidswiss, TheBigLee, wejdross and zugao and removed request for a team December 12, 2024 12:10
@wejdross wejdross merged commit b790fa3 into master Dec 20, 2024
10 checks passed
@wejdross wejdross deleted the appcat/284/fix/default_backup_retetion branch December 20, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants