feature/partytown: Added possibility for user to choose loading outsi… #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de the main thread and validations for use debugging tag assistant
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
danzanzini
suggested changes
Mar 1, 2023
There was a problem hiding this comment.
Hey @carlosviniciusananias. Thanks for the great contribution.
I've requested one change regarding the setting type.
danzanzini
reviewed
Mar 2, 2023
|
@danzanzini Pull request updated with your recommendations. |
danzanzini
suggested changes
Mar 24, 2023
carlosananias
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
The main objective of this request is to enable shopkeepers to load third-party scripts outside the main thread with the help of the partytown library and the vtex application.
What problem is this solving?
Page loading time, considering core web vitals metrics.
How should this be manually tested?
Run the app in any development workspace, configure the google tag manager identifier, select partytown and save.
Just go to the website and make sure the type is text/partytown and then perform load tests.
Screenshots or example usage
Types of changes
New feature (a non-breaking change which adds functionality)
Observation:
In tests carried out, an evolution of 20 points of performance and improvement in fcp, tti, tbt and lcp was noticed.