Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA Event Blocker #149

Merged
merged 8 commits into from
Apr 16, 2024
Merged

GA Event Blocker #149

merged 8 commits into from
Apr 16, 2024

Conversation

diegoleone
Copy link
Contributor

@diegoleone diegoleone commented Mar 22, 2024

What is the purpose of this pull request?

GA Events were being blocked on Add to Wish List because there was a null pointer exception, incase the sku is undefined. This generated a console error.

Test:
https://list--italiaonline.myvtex.com/outsunny-orto-urbano-pensile-tavolo-porta-piante-con-fodera-in-tessuto-per-giardino-91x91x81cm-legno-90980/p

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

vtex-io-ci-cd bot commented Mar 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 22, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

react/modules/gaEvents.ts Outdated Show resolved Hide resolved
@cdcs0128 cdcs0128 self-requested a review April 8, 2024 18:23
Copy link

@cdcs0128 cdcs0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declare selectedItem types

react/modules/gaEvents.ts Outdated Show resolved Hide resolved
react/typings/events.d.ts Outdated Show resolved Hide resolved
react/typings/events.d.ts Outdated Show resolved Hide resolved
@cdcs0128 cdcs0128 requested a review from Mecrano April 16, 2024 15:55
Copy link
Contributor

@Mecrano Mecrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mecrano Mecrano merged commit d2b0e47 into master Apr 16, 2024
3 checks passed
@Mecrano Mecrano deleted the fix-ga-event-blocker branch April 16, 2024 21:42
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 16, 2024

Your PR has been merged! App is being published. 🚀
Version 3.5.3 → 3.5.4

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants