Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic of the useVIewCartPixel hook #335

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Conversation

efremov-av
Copy link
Contributor

@efremov-av efremov-av commented Aug 2, 2024

What problem is this solving?

The app has problems with pushing view_cart pixel event when variant="drawer". This problem happens because of the wrong logic of handling open/close state of the Drawer component. It switches isOpen from true to false and back when user presses on the Cart Button in the store front header:

  1. User presses on the Cart button --> isOpen changes to true --> view_cart event is pushed;
  2. User presses on the close Drawer button --> nothing changed;
  3. User presses on the Cart button --> isOpen changed to false --> view_cart event is not pushed because isOpen state == false.

To solve this wrong behavior I added onVisibilityChanged callback function as a property argument to the Drawer component in the drawer app and made these changes in the minicart app to handle open/close events properly.

How to test it?

In the browser inspector console tab type dataLayer to see events that have been pushed. It should add view_cart event on every Drawer opening and when user adds a new product to the cart (at the moment when Drawer is opening)

https://devalex--dunnesstorespreprod.myvtex.com/

Screenshots or example usage:

minicart.before.changes.mov
minicart.after.changes.mov

Снимок экрана 2024-08-02 в 15 13 17

Related PR

vtex-apps/drawer#75

@efremov-av efremov-av requested a review from a team as a code owner August 2, 2024 08:13
@efremov-av efremov-av requested review from gvc, lariciamota and RodrigoTadeuF and removed request for a team August 2, 2024 08:13
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 2, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

@beatrizmaselli beatrizmaselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job Alex 🚀

@iago1501 iago1501 added the bug Something isn't working label Aug 5, 2024
Copy link
Contributor

@vsseixaso vsseixaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsseixaso vsseixaso merged commit bcbe843 into master Aug 14, 2024
6 checks passed
@vsseixaso vsseixaso deleted the fix/viewCartEvent branch August 14, 2024 13:59
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 14, 2024

Your PR has been merged! App is being published. 🚀
Version 2.67.1 → 2.67.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants