Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove explicit sponsored product call #661

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Apr 19, 2024

What problem is this solving?

This PR does two things:

  • Removes the ability to call sponsored products separately from the product search request;
  • Always sends the param showSponsored as true to the product search request.

Now, we check in the intelligent-search-app if the account supports sponsored products.

How to test it?

  • farmadelivery - This account used to call ads separately from the product search - now, it's only one request.

Related to / Depends on

@hcaula hcaula self-assigned this Apr 19, 2024
@hcaula hcaula requested review from a team as code owners April 19, 2024 19:28
@hcaula hcaula requested review from hellofanny, lucasfp13 and lariciamota and removed request for a team April 19, 2024 19:28
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 19, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@hcaula hcaula merged commit 7721b7b into master Apr 22, 2024
4 of 6 checks passed
@hcaula hcaula deleted the refactor/remove-explicit-sponsored-products-request branch April 22, 2024 20:07
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 22, 2024

Your PR has been merged! App is being published. 🚀
Version 3.130.2 → 3.131.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants