Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: pass placement to product summary and query #668

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Jul 4, 2024

What problem is this solving?

This is optional, but since I'm update the query for products, I'm updating how we call productSearch as well.

I'm using routeId for placement, which should translate to something like search#departments or simply search.

@hcaula hcaula self-assigned this Jul 4, 2024
@hcaula hcaula requested review from a team as code owners July 4, 2024 20:01
@hcaula hcaula requested review from lucasfp13, lariciamota and RodrigoTadeuF and removed request for a team July 4, 2024 20:01
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 4, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@hcaula hcaula merged commit 69c6dba into master Aug 1, 2024
1 of 4 checks passed
@hcaula hcaula deleted the feat/add-search-placement branch August 1, 2024 18:04
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 1, 2024

Your PR has been merged! App is being published. 🚀
Version 3.132.2 → 3.133.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants