Feature displayMode select for Color Variation #1104
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaidanieldumitru
requested review from
georgebrindeiro,
eduardoformiga,
lucasfp13 and
lariciamota
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
645f421
to
659f596
Compare
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
659f596
to
0750245
Compare
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
0750245
to
e771353
Compare
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
e771353
to
2740bfa
Compare
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
2740bfa
to
43cdcc9
Compare
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
43cdcc9
to
f3d7054
Compare
mihaidanieldumitru
force-pushed
the
feature/display-mode-select-for-color-variation
branch
from
f3d7054
to
340be9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This feature is needed in order to render color variations inside shelves using a dropdown. Before the only way was a slider/list of buttons.
How to test it?
Workspace
Screenshots or example usage:
"product-summary-sku-selector#shelf": { "props": { "maxItems": 50, "displayMode": "select", "showVariationsLabels": "none", "initialSelection": "empty", "visibility": "more-than-one", "visibleVariations": ["Culoare"], + "displayModeSelectForColorVariation": true, "blockClass": "defaultShelf" } },