Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add width and height in <img> #1105

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add width and height in <img> #1105

wants to merge 6 commits into from

Conversation

lucvysk
Copy link

@lucvysk lucvysk commented Apr 30, 2024

What problem is this solving?

add width and height in img to improve CLS

How to test it?

https://vysk2--hunterdouglasnl.myvtex.com/

Screenshots or example usage:

image image

@lucvysk lucvysk requested a review from a team as a code owner April 30, 2024 19:52
@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 30, 2024 •
edited by lucvysk
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

Warnings
⚠️

👀 The size of this pull request seems relatively large (>420 modifications). Consider splitting it into smaller pull requests to help make reviews easier and faster.

Generated by 🚫 dangerJS against 8b22e1f

mateussaggin
mateussaggin approved these changes Jul 4, 2024
View reviewed changes
Copy link

@mateussaggin mateussaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vmourac-vtex
vmourac-vtex requested changes Jul 15, 2024
View reviewed changes
Copy link

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change required

  • Missing localization key (see review)
  • Missing documentation for the new parameters in InfoCard.md

store/contentSchemas.json Outdated Show resolved Hide resolved
vmourac-vtex
vmourac-vtex requested changes Jul 15, 2024
View reviewed changes
Copy link

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change required

  • Missing localization key (see review)
  • Missing documentation for the new parameters in InfoCard.md

@lucvysk
Merge branch 'master' into feature/add-size
5b4c283 
# Conflicts:
#	CHANGELOG.md
#	messages/ar.json
#	messages/bg.json
#	messages/de.json
#	messages/en.json
#	messages/es.json
#	messages/fr.json
#	messages/id.json
#	messages/it.json
#	messages/ja.json
#	messages/ko.json
#	messages/nl.json
#	messages/nn.json
#	messages/no.json
#	messages/pt.json
#	messages/ro.json
#	messages/th.json
#	react/components/InfoCard/index.js
@lucvysk
fix: description label in schema
9796d3e
@lucvysk
chore: update doc
8b22e1f
@lucvysk lucvysk requested a review from a team as a code owner October 16, 2024 13:26
@lucvysk
Copy link
Author

lucvysk commented Oct 16, 2024

Minor change required

  • Missing localization key (see review)
  • Missing documentation for the new parameters in InfoCard.md

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateussaggin mateussaggin mateussaggin approved these changes

@gvc gvc Awaiting requested review from gvc gvc is a code owner automatically assigned from vtex-apps/store-framework-devs

@hellofanny hellofanny Awaiting requested review from hellofanny hellofanny is a code owner automatically assigned from vtex-apps/store-framework-devs

@eduardoformiga eduardoformiga Awaiting requested review from eduardoformiga eduardoformiga is a code owner automatically assigned from vtex-apps/store-framework-devs

@kaio-donadelli kaio-donadelli Awaiting requested review from kaio-donadelli kaio-donadelli is a code owner automatically assigned from vtex-apps/technical-writers

@vmourac-vtex vmourac-vtex Awaiting requested review from vmourac-vtex

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucvysk @mateussaggin @vmourac-vtex @sheilagomes