fix: error when no email found in jwt due to email rectification feature #673
Conversation
iago1501
requested review from
eduardoformiga,
lucasfp13 and
leo-prange-vtex
and removed request for
a team
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
iago1501
requested review from
gabpaladino,
vsseixaso,
vmourac-vtex,
rafaelnader and
rafarubim
and removed request for
eduardoformiga and
lucasfp13
| @@ -261,9 +261,10 @@ async function checkUserAccount( | |||
| !( | |||
| tokenUser.account === account && | |||
| (isUserCallCenterOperator || | |||
| tokenUser.user.toLowerCase() === currentProfile?.email.toLowerCase()) | |||
| tokenUser.user.toLowerCase() === currentProfile?.email.toLowerCase() || | |||
| tokenUser.customerId === currentProfile?.userId) | |||
There was a problem hiding this comment.
@iago1501 caso não tenha customerId (caso geral), e o currentProfile seja nulo, vai dar verdadeiro?
There was a problem hiding this comment.
Isso @rafaelnader , é que a lógica desse cara foi feita invertida, também fiquei confuso pra entender.
No teu exemplo, esse condicional de dentro vai dar false, mas tem o bang (!) antes pra inverter e dar verdadeiro, e daí, ele vai disparar o erro porque esse condicional é para disparar o erro.
Basicamente tudo o que ta dentro do parêntese é esperado que retorne true pra ele retornar false e não cair no erro 😵💫
Essa foi sua dúvida?
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Now it's possible to navigate at VTEX without email, it's a new feature called email rectification. In this scenario, the validation must be done by the customerId. From now on, every user will have their own customerId and it's supposed to not use email as a primary key anymore
How to test it?
You must follow several steps in order to create your user with the permissions, so, when reviewing this, please, contact to me so I can give you the access
Before
After
How does this PR make you feel? 🔗