Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postalCode to simulation query for Delivery Promises on IS #676

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

gabiruuuuu
Copy link
Contributor

@gabiruuuuu gabiruuuuu commented Oct 9, 2024

What problem is this solving?

Delivery Promises is a key initiative led by the Order Allocation team in partnership with Intelligent Search, its main goal is to provide a unified system to resolve product availability and use it on Search and Navigation to greatly reduce broken carts because of availability differences on Checkout.

To this end, we need to make changes to how IS uses simulation to fetch Hot prices and stock to start using the postalCode argument.

How to test it?

The changes are optional in the schema and should only affect stores that use the DP feature and will call simulation with the postal code, which at the moment is just one T3 account on closed beta.

Here is an example of an workspace with the updated versions of this app and IS API, for a store that doesn't use DP, to validate that everything still works as intended.

Workspace

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link
Contributor

vtex-io-ci-cd bot commented Oct 9, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 9, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@gabiruuuuu gabiruuuuu changed the title Feature/dp Add postalCode to simulation query for Delivery Promises on IS Oct 9, 2024
@gabiruuuuu gabiruuuuu marked this pull request as ready for review October 9, 2024 15:35
@gabiruuuuu gabiruuuuu requested a review from a team as a code owner October 9, 2024 15:35
@gabiruuuuu gabiruuuuu requested review from gabpaladino, vsseixaso and RodrigoTadeuF and removed request for a team October 9, 2024 15:35
@iago1501 iago1501 requested review from iago1501 and removed request for gabpaladino, vsseixaso and RodrigoTadeuF October 10, 2024 13:44
Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iago1501 iago1501 merged commit c51fcfb into master Oct 10, 2024
7 checks passed
@iago1501 iago1501 deleted the feature/dp branch October 10, 2024 15:57
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 10, 2024

Your PR has been merged! App is being published. 🚀
Version 2.171.2 → 2.172.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants