-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-root workspace #1928
Conversation
Works great! |
C'mon, merge this. |
@dodas I don't think this is going to be merged relatively soon. What you can do is the following:
|
I said it works great, that means I'm already using it.. Vetur is Vue's official development tool and experience using it (especially in bigger projects) is just shit. There are many bugs that have fixes waiting in PRs, yet we don't even get any feedback about when/if they are going to be merged. |
#1734 ? |
@Minigugus I saw the PR after submitting this one. Decided not to close it, because it's using a different strategy and I was not convinced which one is better, so I'll leave it to the maintainers to decide. :) |
I've noticed it too 👍 Yours seems to create one setup per root whereas mine creates one per folder (heavier but supports nested tsconfig 😜)
The maintainers still have to answer (was initially my previous message's purpose) 😆 Perhaps we can take the best of both worlds until maintainers react 😄 |
@vojvodics Could you please open the PR against this relatively popular fork of Vetur? I could do that myself, but you did all the work! :) Here's the link to help you open the PR in 1 click: https://github.com/hikerpig/vetur/compare/master...vojvodics:master?expand=1 |
Fixed Merge conflicts here: #2129 |
Should fix #424 and #815
Following the example at https://github.com/Microsoft/vscode-extension-samples/tree/master/lsp-multi-server-sample
It creates a new VLS for each of the workspace folders.
I'll need help to add proper test coverage and check if every command is working properly (every test passes, but it's probably not tested against multi-root workspace).