-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transition boolean props complete #2627
base: master
Are you sure you want to change the base?
Conversation
69827ce
to
a2f34c2
Compare
a2f34c2
to
0613efe
Compare
I'm not sure this is a good change. It looks like changing here is also a possible direction.
@octref What do you think? |
vetur/server/src/modes/template/tagProviders/htmlTags.ts Lines 155 to 157 in 5b89f1e
vetur/server/src/modes/template/tagProviders/htmlTags.ts Lines 528 to 531 in 5b89f1e
Vue's boolean attributes does allow a Changing that line to Footnotes |
getAttribute( | ||
'css', | ||
'b', | ||
'v', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option default is true.
So we need =""
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes it should be.
@@ -133,7 +133,7 @@ const vueTags = { | |||
const valueSets = { | |||
transMode: ['out-in', 'in-out'], | |||
transType: ['transition', 'animation'], | |||
b: ['true', 'false'] | |||
v: ['true', 'false'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also need to keep b
.
I am not so familiar with this part. Footnotes |
To complete without
=""
, the type needed to be"v"
instead of"b"
.