Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Testing Actions Documentation to No Longer Reference inject-loader #2155

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhao-li
Copy link

@zhao-li zhao-li commented Apr 4, 2022

Hi,

This PR removes references to inject-loader from the Testing Actions section. inject-loader is no longer working/supported, based on this issue: vuejs/vue-cli#947

I fell into the same trap (that others have expressed in that ticket) of trying to get my tests to work following the example code, but only to find out that the inject-loader example code no longer works.

I hope that by removing the example code that doesn't work, it can save other newbies like me some time.

I also added a Jest example in case that can be helpful to others.

Sorry if this PR is not the right format. I tried to follow the contribution guidelines, but could not find a version 4 branch or a dev branch in the repo.

Please let me know if there's anything else I should modify.

Thanks for building such a great product and providing well-written documentation. 🙏

… it no longer works and causes confusion for beginners. Use the existing spy implementation instead.
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for vuex-docs ready!

Name Link
🔨 Latest commit b9b860f
🔍 Latest deploy log https://app.netlify.com/sites/vuex-docs/deploys/624a8a8914904600080ecc55
😎 Deploy Preview https://deploy-preview-2155--vuex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant