-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helper): add sass helper #199
Draft
pengzhanbo
wants to merge
5
commits into
main
Choose a base branch
from
sass-helper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+79
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9394401039Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9394443394Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9395563100Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9395562812Details
💛 - Coveralls |
我的意思是跟src并列,这样你只需要在files里生明就可以了 |
还是跟 client/node/shared 保持相同的层级吧,放到 src 同层级,结构上看起来有些割裂。 |
Pull Request Test Coverage Report for Build 9400170277Details
💛 - Coveralls |
我并不觉得他割裂,其他包已经有诸如template 这样的文件夹了。而且你也很难说他是一个需要经过编译的source |
Pull Request Test Coverage Report for Build 10009633184Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Input:
Output: