Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin-markdown-chart #249

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11458849266

Details

  • 103 of 104 (99.04%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.0%) to 59.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-markdown-chart/src/node/markdown-it-plugins/mermaid.ts 19 20 95.0%
Totals Coverage Status
Change from base Build 11445244285: 2.0%
Covered Lines: 1276
Relevant Lines: 1924

💛 - Coveralls

@Mister-Hope
Copy link
Member Author

@pengzhanbo I have some issues with katex in markmap, helps would be appreciated.

@pengzhanbo
Copy link
Member

pengzhanbo commented Oct 13, 2024

I have some issues with katex in markmap, helps would be appreciated.

I haven't used markmap before. I read its documentation and the code of the Markmap component in the plugin, and I did not find any obvious issues. However, I noticed that markmap-view depends on d3, and I'm not sure if that has any impact. Perhaps we can refer to markmap-autoloader to adjust the loading logic of the markmap component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] add @vuepress/plugin-markdown-chart
3 participants