Updates Web3dev's deployment of Forem to latest version #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Auto confirm flag reactions when spam role is assigned * Renamed method according to its point --------- Co-authored-by: Mac Siri <[email protected]>
* add test to mark profile as spam * rubocop * move test
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Move calculating comments score from worker to a service * Display displayed comments count in feed * Recalculating displayed comments counts on article show (if needed) * Rubocop fixes * Fixed lambda
Co-authored-by: Mac Siri <[email protected]>
…orem#20744) Co-authored-by: Mac Siri <[email protected]>
) * Initial controller creation * Ahoy custom clicks initial WIP * Add test for success and failure * Adjust some tests * Adjust test * Adjust tests and some code * Update app/views/mailers/digest_mailer/digest_email.html.erb * Remove s/t/u from safe params * Add simple test * Update app/controllers/ahoy/custom_email_clicks_controller.rb Co-authored-by: Mac Siri <[email protected]> * Change to just email clicks * Email clicks controller test --------- Co-authored-by: Mac Siri <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…ot confirmed (forem#20831) * Show reconfirmation option on users profile * spec
* Replace edge extension * Put name attributes at the top for consistency
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Mac Siri <[email protected]>
cancelei
had a problem deploying
to
cancelei_development
GitHub Actions
Failure
|
@cancelei , first off, thank you for your contribution! Could you provide more context about what this PR is addressing? While I recall you are working on updating the Forem version, other team members might not have that context, and even I might not remember all the details in the future. It's helpful to include a clear summary of what you've done and the reasoning behind it, even if it feels redundant compared to your commit messages. Providing this information ensures the whole team is on the same page and makes it easier to review and track the purpose of the changes later on. For reference, here's a good example from one of our other repositories: PR #153. |
|
I believe this PR should be directed to the |
cancelei
changed the title
cancelei
changed the title
cancelei
had a problem deploying
to
cancelei_development
GitHub Actions
Failure
* More throttling for billboard tabulating * Update app/controllers/billboard_events_controller.rb
* Add role targeting to billboards * Complete form * Complete form * Fix api spec * Finalize tests
* Add bb param to billboards after save * Handle edge cases
This reverts commit 1ef85cc.
This reverts commit 734e10c.
…opment" This reverts commit 706cbbc.
* Add proper self-serve subscription cancel flow * Make tweak to billboard display
* Track external email clicks via redirect * Gem upgrades * Add ahoy to vcl logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Pull Request:
Bug Fix
New Feature
-> Others
What does this PR do?
Admins from Web3dev reported that their Forem deployment was outdated. This PR brings the correct code to deploy an updated version.
Updated target branch from main to 'web3dev-version'.
The original PR also includes a mechanism to create a Docker Image, that was removed due to stakeholder prioritization.
Additional Context
When running the repo locally without containers use the rails command to build the db from the existing schema.
To start: Run Redis locally and use bin/setup then bin/startup (to run the app locally again).
With Docker container (with running docker) :
gem install dip
dip provision (builds the image)
dip rails s
Result:
Closes Issue
null