Specify account labels #669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm1
reviewed
Oct 30, 2024
| 1. If |config|.{{IdentityProviderAPIConfig/accounts}}.{{IdentityProviderLabelConfig/include}} | ||
| was specified: | ||
| 1. For every |account| in |accountList|, remove |account| from |accountList| if |account|'s | ||
| {{IdentityProviderAccount/labels}} does not [=list/contain=] |
There was a problem hiding this comment.
Why the discrepancy between labels and include?
There was a problem hiding this comment.
I mean, this is what we settled on in the explainer. I don't recall why we made this choice specifically, though. @samuelgoto do you remember?
| @@ -1053,13 +1059,18 @@ dictionary IdentityProviderBranding { | |||
| USVString name; | |||
| }; | |||
|
|
|||
| dictionary IdentityProviderLabelConfig { | |||
There was a problem hiding this comment.
A dictionary with a single string? What are we thinking this could be extended to?
There was a problem hiding this comment.
"exclude" is the obvious one. Conceivably we could also allow specifying multiple labels (could require all of them to match or just one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #553
Preview | Diff