Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stability text if there are multiple groups #1820

Merged
merged 1 commit into from
Mar 19, 2024
Merged

update stability text if there are multiple groups #1820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/rules/sotd/stability.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,21 @@ function findSW(candidates, sr) {
'A W3C Registry is a specification that, after extensive consensus-building, is endorsed by W3C and its Members.';
} else {
const { crType } = sr.config;
const INTRO_S =
' A Candidate Recommendation Snapshot has received wide review, is intended to gather implementation experience, and has commitments from Working Group members to royalty-free licensing for implementations.';
const INTRO_D =
' A Candidate Recommendation Draft integrates changes from the previous Candidate Recommendation that the Working Group intends to include in a subsequent Candidate Recommendation Snapshot.';
const groupIds = sr.getDelivererIDs();
const INTRO_S = ` A Candidate Recommendation Snapshot has received wide review, is intended to gather implementation experience, and has commitments from Working Group${
groupIds.length > 1 ? 's' : ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
groupIds.length > 1 ? 's' : ''
groupIds.length > 1 ? "s'" : ''

Context: https://github.com/speced/bikeshed-boilerplate/pull/62/files#r1528428357

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anssiko thanks for the suggestion. After checking with our head of comm, both versions appeared to be correct.
Now, the suggestion would also apply if there's a single group. So to avoid having to update both bikeshed and respec, I'm tempted to keep the current version of the sentence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking with comms folks. I'm fine with whatever is grammatically correct, so let's keep the current.

} members to royalty-free licensing for implementations.`;
const INTRO_D = ` A Candidate Recommendation Draft integrates changes from the previous Candidate Recommendation that the Working Group${
groupIds.length > 1 ? 's intend' : ' intends'
} to include in a subsequent Candidate Recommendation Snapshot.`;
const CR_INTRO = crType === 'Draft' ? INTRO_D : INTRO_S;

const { cryType } = sr.config;
const INTRO_CRY =
' A Candidate Registry Snapshot has received wide review.';
const INTRO_CRYD =
' A Candidate Registry Draft integrates changes from the previous Candidate Registry that the Working Group intends to include in a subsequent Candidate Registry Snapshot.';
const INTRO_CRYD = ` A Candidate Registry Draft integrates changes from the previous Candidate Registry that the Working Group${
groupIds.length > 1 ? 's intend' : ' intends'
} to include in a subsequent Candidate Registry Snapshot.`;
const CRY_INTRO = cryType === 'Draft' ? INTRO_CRYD : INTRO_CRY;
sw = null;
const article =
Expand Down
Loading