-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Pass Through of BBS Presentation header #129
Conversation
Where does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See a couple of minor suggestions.
`nonMandatory` to the values associated with their property | ||
names in the object returned when calling the algorithm in Section | ||
Initialize `bbsProof`, `proofHash`, `mandatoryHash`, `selectedIndexes`, | ||
`presentationHeader` and `nonMandatory` to the values associated with their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need a note that says that implementations can surface the presentationHeader
for external use if desired (perhaps to compare a challenge or something like that in a protocol that uses the VCDM). Nothing in the spec text prevents them from doing so, but it might be helpful to have a note like this:
Note: Implementations are free to expose any component parsed from the proof data for external use or to compare them internally against externally provided values based on protocol needs. For example, an implementation might expose
presentationHeader
for comparison against an expected pseudo-random challenge value used in a presentation protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlongley I'm thinking we put this as an informational note at the end of section 3.3.7 Verify Derived Proof (bbs-2023). Other ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wind4Greg, that sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normative, multiple reviews, changes requested and made, no objections, merging.
A hash of the canonicalized proof graph (sans |
Ahh apologies, I may have misunderstood. Is it then correct that there is no BBS Cryptosuite-based verifiable presentation holding the derived credential? Instead then, the expectation is that there is some interoperable protocol which is exchanging derived credentials, and that protocol will define the contents of |
It's still possible for someone to use a VP that contains a VC with a BBS-derived proof. The goal here is just to enable use of the |
…te array. Co-authored-by: Dave Longley <[email protected]>
…ames. Co-authored-by: Ted Thibodeau Jr <[email protected]>
Probably better to resolve merge conflicts before I re-review |
…d formatting improvements for variable names. Co-authored-by: Ted Thibodeau Jr <[email protected]>
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR addresses issue #122 to enable the passing through of the BBS presentation header. This would be used between a holder and a verifier.
See the BBS draft specification section 6.4. Presentation Header Selection where use is RECOMMENDED in most use-cases. Useful for such things as preventing replay attacks, etc...
Preview | Diff