Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New principle: Return undefined from side-effect-causing functions. #500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

New principle: Return undefined from side-effect-causing functions. #500

wants to merge 2 commits into from

Conversation

hober
Copy link
Contributor

@hober hober commented Jul 15, 2024 •
edited by pr-preview bot
Loading

Fixes #286.

Preview | Diff

@hober hober self-assigned this Jul 15, 2024
LeaVerou
LeaVerou approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this takes semantic line breaking to an extreme and makes the markup harder to read, but +1 on the content.

We probably need a principle on command-query separation, but that's a separate issue.

domenic
domenic approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with editorial nit

index.bs Outdated Show resolved Hide resolved
@hober @domenic
Update index.bs
05a8f15 
Co-authored-by: Domenic Denicola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@LeaVerou LeaVerou LeaVerou approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson

@annevk annevk Awaiting requested review from annevk

Assignees

@hober hober

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guidance about return values of (conceptually) void functions
3 participants
@hober @LeaVerou @domenic