Set "secret" env vars in the test GH action.

w3ctag · Oct 1, 2024 · 6e9be1b · 6e9be1b
1 parent c45794a
commit 6e9be1b
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 95 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,6 +13,8 @@ env:
 jobs:
   test:
     runs-on: ubuntu-latest
+    env:
+      DATABASE_URL: file:./test.db
     steps:
       - uses: actions/checkout@v4
       - name: Setup pnpm
@@ -23,7 +25,15 @@ jobs:
           node-version-file: "package.json"
           cache: pnpm
       - run: pnpm install
-      - run: pnpm test
+      - run: pnpm prisma db push
+      - name: Make a private key for testing.
+        run: openssl genrsa -traditional -out testkey.pem
+      - name: Run tests
+        run: PRIVATE_KEY=$(cat testkey.pem) pnpm test
+        env:
+          # Generated just for this file and never used elsewhere.
+          CLIENT_SECRET: 6d5e528bb01faa2de86ef59dacbdca0b4a406e09
+          WEBHOOK_SECRET: 37651a9cf25c2d370308aee98ce0b7c9a6bfc30c
 
   build:
     runs-on: ubuntu-latest

diff --git a/.gitignore b/.gitignore
@@ -25,4 +25,4 @@ pnpm-debug.log*
 .idea/
 
 # Default database location
-prisma/dev.db
+prisma/*.db
diff --git a/test/webhook.test.ts b/test/webhook.test.ts
@@ -1,4 +1,5 @@
 import type { EmitterWebhookEvent } from "@octokit/webhooks";
+import { REVIEWS_REPO } from "astro:env/client";
 import { afterEach, beforeEach, describe, expect, test } from "vitest";
 import { app } from "../src/lib/github";
 import prisma from "../src/lib/prisma";
@@ -19,16 +20,12 @@ describe("issues", () => {
       const payload = JSON.stringify({
         action: "opened",
         issue: {
-          url: "https://api.github.com/repos/jyasskin/test-design-reviews/issues/9",
-          repository_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews",
-          labels_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues/9/labels{/name}",
-          comments_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues/9/comments",
-          events_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues/9/events",
-          html_url: "https://github.com/jyasskin/test-design-reviews/issues/9",
+          url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/9`,
+          repository_url: `https://api.github.com/repos/${REVIEWS_REPO}`,
+          labels_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/9/labels{/name}`,
+          comments_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/9/comments`,
+          events_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/9/events`,
+          html_url: `https://github.com/${REVIEWS_REPO}/issues/9`,
           id: 2539552022,
           node_id: "Issue9Id",
           number: 9,
@@ -77,7 +74,7 @@ describe("issues", () => {
           active_lock_reason: null,
           body,
           reactions: {
-            url: "https://api.github.com/repos/jyasskin/test-design-reviews/issues/9/reactions",
+            url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/9/reactions`,
             total_count: 0,
             "+1": 0,
             "-1": 0,
@@ -88,16 +85,15 @@ describe("issues", () => {
             rocket: 0,
             eyes: 0,
           },
-          timeline_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues/9/timeline",
+          timeline_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/9/timeline`,
           performed_via_github_app: null,
           state_reason: null,
         },
         repository: {
           id: 849574210,
           node_id: "R_kgDOMqN5Qg",
           name: "test-design-reviews",
-          full_name: "jyasskin/test-design-reviews",
+          full_name: REVIEWS_REPO,
           private: false,
           owner: {
             login: "jyasskin",
@@ -124,89 +120,53 @@ describe("issues", () => {
             type: "User",
             site_admin: false,
           },
-          html_url: "https://github.com/jyasskin/test-design-reviews",
+          html_url: `https://github.com/${REVIEWS_REPO}`,
           description: "Repository to test cloning design-reviews issues",
           fork: false,
-          url: "https://api.github.com/repos/jyasskin/test-design-reviews",
-          forks_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/forks",
-          keys_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/keys{/key_id}",
-          collaborators_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/collaborators{/collaborator}",
-          teams_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/teams",
-          hooks_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/hooks",
-          issue_events_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues/events{/number}",
-          events_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/events",
-          assignees_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/assignees{/user}",
-          branches_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/branches{/branch}",
-          tags_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/tags",
-          blobs_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/git/blobs{/sha}",
-          git_tags_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/git/tags{/sha}",
-          git_refs_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/git/refs{/sha}",
-          trees_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/git/trees{/sha}",
-          statuses_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/statuses/{sha}",
-          languages_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/languages",
-          stargazers_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/stargazers",
-          contributors_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/contributors",
-          subscribers_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/subscribers",
-          subscription_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/subscription",
-          commits_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/commits{/sha}",
-          git_commits_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/git/commits{/sha}",
-          comments_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/comments{/number}",
-          issue_comment_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues/comments{/number}",
-          contents_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/contents/{+path}",
-          compare_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/compare/{base}...{head}",
-          merges_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/merges",
-          archive_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/{archive_format}{/ref}",
-          downloads_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/downloads",
-          issues_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/issues{/number}",
-          pulls_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/pulls{/number}",
-          milestones_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/milestones{/number}",
-          notifications_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/notifications{?since,all,participating}",
-          labels_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/labels{/name}",
-          releases_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/releases{/id}",
-          deployments_url:
-            "https://api.github.com/repos/jyasskin/test-design-reviews/deployments",
+          url: `https://api.github.com/repos/${REVIEWS_REPO}`,
+          forks_url: `https://api.github.com/repos/${REVIEWS_REPO}/forks`,
+          keys_url: `https://api.github.com/repos/${REVIEWS_REPO}/keys{/key_id}`,
+          collaborators_url: `https://api.github.com/repos/${REVIEWS_REPO}/collaborators{/collaborator}`,
+          teams_url: `https://api.github.com/repos/${REVIEWS_REPO}/teams`,
+          hooks_url: `https://api.github.com/repos/${REVIEWS_REPO}/hooks`,
+          issue_events_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/events{/number}`,
+          events_url: `https://api.github.com/repos/${REVIEWS_REPO}/events`,
+          assignees_url: `https://api.github.com/repos/${REVIEWS_REPO}/assignees{/user}`,
+          branches_url: `https://api.github.com/repos/${REVIEWS_REPO}/branches{/branch}`,
+          tags_url: `https://api.github.com/repos/${REVIEWS_REPO}/tags`,
+          blobs_url: `https://api.github.com/repos/${REVIEWS_REPO}/git/blobs{/sha}`,
+          git_tags_url: `https://api.github.com/repos/${REVIEWS_REPO}/git/tags{/sha}`,
+          git_refs_url: `https://api.github.com/repos/${REVIEWS_REPO}/git/refs{/sha}`,
+          trees_url: `https://api.github.com/repos/${REVIEWS_REPO}/git/trees{/sha}`,
+          statuses_url: `https://api.github.com/repos/${REVIEWS_REPO}/statuses/{sha}`,
+          languages_url: `https://api.github.com/repos/${REVIEWS_REPO}/languages`,
+          stargazers_url: `https://api.github.com/repos/${REVIEWS_REPO}/stargazers`,
+          contributors_url: `https://api.github.com/repos/${REVIEWS_REPO}/contributors`,
+          subscribers_url: `https://api.github.com/repos/${REVIEWS_REPO}/subscribers`,
+          subscription_url: `https://api.github.com/repos/${REVIEWS_REPO}/subscription`,
+          commits_url: `https://api.github.com/repos/${REVIEWS_REPO}/commits{/sha}`,
+          git_commits_url: `https://api.github.com/repos/${REVIEWS_REPO}/git/commits{/sha}`,
+          comments_url: `https://api.github.com/repos/${REVIEWS_REPO}/comments{/number}`,
+          issue_comment_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues/comments{/number}`,
+          contents_url: `https://api.github.com/repos/${REVIEWS_REPO}/contents/{+path}`,
+          compare_url: `https://api.github.com/repos/${REVIEWS_REPO}/compare/{base}...{head}`,
+          merges_url: `https://api.github.com/repos/${REVIEWS_REPO}/merges`,
+          archive_url: `https://api.github.com/repos/${REVIEWS_REPO}/{archive_format}{/ref}`,
+          downloads_url: `https://api.github.com/repos/${REVIEWS_REPO}/downloads`,
+          issues_url: `https://api.github.com/repos/${REVIEWS_REPO}/issues{/number}`,
+          pulls_url: `https://api.github.com/repos/${REVIEWS_REPO}/pulls{/number}`,
+          milestones_url: `https://api.github.com/repos/${REVIEWS_REPO}/milestones{/number}`,
+          notifications_url: `https://api.github.com/repos/${REVIEWS_REPO}/notifications{?since,all,participating}`,
+          labels_url: `https://api.github.com/repos/${REVIEWS_REPO}/labels{/name}`,
+          releases_url: `https://api.github.com/repos/${REVIEWS_REPO}/releases{/id}`,
+          deployments_url: `https://api.github.com/repos/${REVIEWS_REPO}/deployments`,
           created_at: "2024-08-29T20:54:51Z",
           updated_at: "2024-08-30T17:23:30Z",
           pushed_at: "2024-08-30T17:23:27Z",
-          git_url: "git://github.com/jyasskin/test-design-reviews.git",
-          ssh_url: "[email protected]:jyasskin/test-design-reviews.git",
-          clone_url: "https://github.com/jyasskin/test-design-reviews.git",
-          svn_url: "https://github.com/jyasskin/test-design-reviews",
+          git_url: `git://github.com/${REVIEWS_REPO}.git`,
+          ssh_url: `[email protected]:${REVIEWS_REPO}.git`,
+          clone_url: `https://github.com/${REVIEWS_REPO}.git`,
+          svn_url: `https://github.com/${REVIEWS_REPO}`,
           homepage: null,
           size: 11,
           stargazers_count: 0,
@@ -272,7 +232,7 @@ describe("issues", () => {
       );
       expect(await response.text()).toEqual("");
       expect(response).toHaveProperty("status", 200);
-      const result = await prisma.designReview.findUnique({
+      const result = await prisma.designReview.findUniqueOrThrow({
         where: { id: "Issue9Id" },
         include: { labels: { select: { label: true } } },
       });