Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static pages 마이그레이션 #271

Merged
merged 5 commits into from
Sep 19, 2024
Merged

static pages 마이그레이션 #271

merged 5 commits into from
Sep 19, 2024

Conversation

asp345
Copy link
Member

@asp345 asp345 commented Sep 14, 2024

No description provided.

@asp345 asp345 requested review from PFCJeong and a team as code owners September 14, 2024 11:33
@asp345 asp345 requested review from davin111, Hank-Choi and SeonghaeJo and removed request for a team September 14, 2024 11:33
import java.time.Duration

@Component
class StaticPageHandler : ServiceHandler(Middleware.NoOp) {
Copy link
Contributor

@SeonghaeJo SeonghaeJo Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ServiceHandler(Middleware.NoOp)를 상속받지 않아도 될 것 같습니다

Copy link
Contributor

@SeonghaeJo SeonghaeJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞으로 정적 페이지를 더 많이 제공할 수도 있다고 생각하면, ServiceHandler처럼 StaticPageHandlerabstract class로 만들어서 정적 페이지만을 위한 공통 로직을 빼도 될 것 같기도 하네요. 근데 그럴 일 딱히 없을 것 같아서 지금 코드 좋은 것 같습니다 ㅎㅎ

@asp345 asp345 merged commit 7eacbcf into develop Sep 19, 2024
2 checks passed
@asp345 asp345 deleted the feature/static-resource branch September 20, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants