식샤 스프링 dev 서버 추가 #228
Open
식샤 스프링 dev 서버 추가 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tictactoeid
commented
Nov 20, 2024
| operator: Equal | ||
| value: dev | ||
| containers: | ||
| - image: 405906814034.dkr.ecr.ap-northeast-2.amazonaws.com/siksha-dev/siksha-spring-server |
There was a problem hiding this comment.
아직 이미지가 없어서 tag는 안 붙였습니다. 배포가 급한 건은 아니어서 추후 수정해서 머지하면 될 것 같습니다.
There was a problem hiding this comment.
한번 ecr에 올린 뒤에 붙이면 될 것 같습니다. 로직은 waffle heimdall 레포 내 람다 코드 다시 확인해봐야할 것 같아요.
| app: siksha-spring-server | ||
| namespace: siksha-dev | ||
| spec: | ||
| replicas: 1 |
There was a problem hiding this comment.
replica 1이면 롤링 업데이트가 당장 효과는 없겠군요..ㅎㅎ
| memory: 256Mi | ||
| limits: | ||
| cpu: 200m | ||
| memory: 256Mi |
There was a problem hiding this comment.
이부분은 혹시 어떤 서비스를 참고하신건가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
식샤 서버를 spring으로 이전하려는 계획이 있어, 와플 인프라에 dev 서버를 추가하고자 합니다.
와플 내 다른 서비스 배포 PR이나 식샤 yaml 파일 참고하였습니다.
제가 k8s를 처음 다루어 봐서, 개선점 있으면 리뷰 부탁드립니다..!
https://github.com/wafflestudio/siksha-spring
TODO