Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon tidy-ups #309

Closed
wants to merge 3 commits into from
Closed

Favicon tidy-ups #309

wants to merge 3 commits into from

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Nov 5, 2022

Based on https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs

To-Do:

  • finish the svg favicon. Could use some help here @nicklee (bonus points: use @media (prefers-color-scheme: dark) for dark mode styling in the same svg)
  • export a 512x512 variant to wagtailio/static/img/favicons/android-icon-512x512.png (currently it is a copy of the 192x192 one)

Nice to have - revised favicon. currently is using the old #43b1b0 background. Could probably move to the #2e1f5e (as the primary colour in Wagtail 4) or the grey one as in the default sharing image

@zerolab zerolab changed the base branch from main to next November 5, 2022 10:38
Base automatically changed from next to main November 14, 2022 12:29
@zerolab
Copy link
Collaborator Author

zerolab commented Mar 9, 2023

@vossisboss would be cool if you could stir up some resources for this, if at all possible
tl;dr -- need a nice SVG logo variant, ideally with a dark scheme version

@vossisboss
Copy link
Collaborator

@zerolab So just to confirm, we need two variants (light and dark) on a new favicon that can be exported to dimensions of 512 X512?

If that's the case, I might be able to get Ben to slip it in next week when he rotates into his Wagtail design time.

@zerolab
Copy link
Collaborator Author

zerolab commented Mar 10, 2023

@vossisboss that's right

@nicklee
Copy link
Member

nicklee commented Jul 25, 2023

Images added, including a dark mode. The Favicon is now a closer crop of the wagtail's head.

Screenshot 2023-07-25 at 08 41 08

@nicklee
Copy link
Member

nicklee commented Jul 25, 2023

I've just merged this into the new dark mode MR here: #391

Semi linked now we have a dark mode favicon :)

@nicklee nicklee closed this Jul 25, 2023
@nicklee nicklee mentioned this pull request Jul 25, 2023
@zerolab zerolab deleted the chore/misc-tidy-ups branch July 25, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants