Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dockerfile to use AWS CLI v2 #389

Closed
wants to merge 1 commit into from

Conversation

vossisboss
Copy link
Collaborator

The make build command was failing because it seems the AWS CLI file we were using is no longer available for download. I updated the commands in the Dockerfile to use AWS CLI version 2.

I tested the updated code with a fresh build in Docker on my local machine. I would appreciate someone else who has production access testing that this update works on their machine as well before merging this commit.

@cnk
Copy link
Member

cnk commented Jul 12, 2023

I tried this out in my Intel-based Mac. The version currently on main (using https://s3.amazonaws.com/aws-cli/awscli-bundle.zip) does not build at all. The new version (using https://awscli.amazonaws.com/awscli-exe-linux-aarch64.zip) builds for me but I don't appear to be able to use the aws CLI.

wagtailio@f3a3a21c0705:/app$ aws --help
qemu-aarch64: Could not open '/lib/ld-linux-aarch64.so.1': No such file or directory
wagtailio@f3a3a21c0705:/app$ which aws
/usr/local/bin/aws

To decide if this PR is the correct solution I think we need to know

  1. What architecture is correct for the production deploy to Heroku (and is creating the correct production container taken care of by a GitHub actions pipeline)?
  2. What architecture(s) do we want to support in development. Do we need to support both M1/ARM and Intel containers for development? If not, then we need to be clearer about which architectures can use the Docker Compose installation - and steer everyone else to ? Vagrant ? or local installation?

@RealOrangeOne
Copy link
Member

The best way to handle this is to use atrictly amd64 (x86) containers, and instruct macOS to run the containers in a compatibility layer (which is very simple). The issue here is that the "aarch64" builds are ARM only, so won't work anywhere else.

@nicklee
Copy link
Member

nicklee commented Jul 18, 2023

This has fixed my build on apple silicion 👍

@vossisboss
Copy link
Collaborator Author

@RealOrangeOne You said in a separate discussion that AWS-CLI is not strictly necessary for our containers. So should we just remove AWS-CLI?

@thibaudcolas
Copy link
Member

Closing in favour of #392 as Sage has approved that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants