chore: remove prettier, and default to eslint (#1495)

* rm: unwanted commit ff3ffdd

* prettier: readds trailing commas

* update: .vscode settings to use eslint by default

* run eslint -- removes trailing commas

* remove: prettier

* remove linting from autogen proto

* address comments

* lint .eslintrc.json

.eslintrc.json

@@ -22,7 +22,6 @@
         "trailingComma": "none"
       }
     ],
-    "comma-dangle": ["error", "never"],
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "eslint-comments/disable-enable-pair": [
@@ -68,9 +67,6 @@
   "overrides": [
     {
       "files": ["*.spec.ts", "**/test_utils/*.ts", "*.js", "*.cjs"],
-      "env": {
-        "node": true
-      },
       "rules": {
         "@typescript-eslint/no-non-null-assertion": "off",
         "@typescript-eslint/no-explicit-any": "off",

.vscode/settings.json

@@ -1,7 +1,11 @@
 {
   "cSpell.userWords": [], // only use words from .cspell.json
   "cSpell.enabled": true,
-  "editor.formatOnSave": true,
+  "editor.defaultFormatter": "dbaeumer.vscode-eslint",
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  },
+  "editor.formatOnSave": false, // Disable general format on save
   "typescript.tsdk": "node_modules/typescript/lib",
   "typescript.enablePromptUseWorkspaceTsdk": true
 }

package.json

@@ -24,10 +24,8 @@
     "size": "npm run build && size-limit",
     "fix": "run-s fix:*",
     "fix:workspaces": "npm run fix --workspaces --if-present",
-    "fix:prettier": "prettier ./packages --write",
     "check": "run-s check:*",
     "check:workspaces": "npm run check --workspaces --if-present",
-    "check:prettier": "prettier ./packages --list-different",
     "check:ws": "[ $(ls -1 ./packages|wc -l) -eq $(cat package.json | jq '.workspaces | length') ] || exit 1 # check no packages left behind",
     "test": "npm run test --workspaces --if-present",
     "test:browser": "npm run test:browser --workspaces --if-present",
@@ -52,17 +50,13 @@
     "gh-pages": "^5.0.0",
     "husky": "^8.0.3",
     "lint-staged": "^13.2.2",
-    "prettier": "^3.0.0",
     "size-limit": "^8.1.2",
     "typedoc": "^0.23.26",
     "typedoc-plugin-resolve-crossmodule-references": "^0.3.3"
   },
   "lint-staged": {
     "*.{ts,js}": [
       "eslint --fix"
-    ],
-    "*.{ts,json,js,md,cjs}": [
-      "prettier --write"
     ]
   }
 }