chore: improve preparePushMessage #1509
Conversation
| @@ -27,6 +27,16 @@ const log = debug("waku:light-push"); | |||
| export const LightPushCodec = "/vac/waku/lightpush/2.0.0-beta1"; | |||
| export { PushResponse }; | |||
|
|
|||
| type PreparePushMessageResult = | |||
There was a problem hiding this comment.
we can move this to @waku/interfaces
There was a problem hiding this comment.
we can move this to
@waku/interfaces
Hum, not sure I agree. preparepush is not really part of the push protocol and it's an internal type.
There was a problem hiding this comment.
imo all interfaces/types should exist in @waku/interfaces
There was a problem hiding this comment.
it's meant to store common interfaces, not all types.
There was a problem hiding this comment.
i'd suggest to have an internal types folder in the monorepo.. helps maintain readability and structure
There was a problem hiding this comment.
I am against moving all types to @waku/interfaces and I think it is better to dedicate it for shared between packages/public types.
PreparePushMessageResult I would perceive as a private local variable so it makes sense to keep only within the file.
…nto weboko/lightpush-send
size-limit report 📦
|
Tiny follow-up to #1487