feat: use the lowest latency peer for light protocols #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u into feat/px-default
…at/select-fastest-peer
danisharora099
commented
Sep 5, 2023
| @@ -4,25 +4,59 @@ import type { KeepAliveOptions } from "@waku/interfaces"; | |||
| import debug from "debug"; | |||
| import type { PingService } from "libp2p/ping"; | |||
|
|
|||
| import { createEncoder } from "../index.js"; | |||
| import { createEncoder } from "./message/version_0.js"; | |||
There was a problem hiding this comment.
while unrelated to this PR, this was causing a cyclic dependency error that surfaced during this PR
danisharora099
commented
Sep 5, 2023
|
|
||
| export const RelayPingContentTopic = "/relay-ping/1/ping/null"; | ||
| const log = debug("waku:keep-alive"); | ||
|
|
||
| export class KeepAliveManager { | ||
| private static instance: KeepAliveManager; |
There was a problem hiding this comment.
converted this into a singleton for easier access (also consistent with ConnectionManager)
danisharora099
force-pushed
the
feat/select-fastest-peer
branch
from
b0aa42f
to
d28647a
Compare
…at/select-fastest-peer
…at/select-fastest-peer
|
superseded by #1540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!#1469 should be merged first!!
Problem
During selection of peers to be used for light protocols, the selection currently happens randomly. This is not ideal, as we might potentially be communicating with a higher latency node, while an option to use a faster node might exist.
Ref: #1465 #1497
Solution