-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add p2p-circuit component to multiaddr that supports it #1531
Conversation
size-limit report 📦
|
// if the multiaddr contains `p2p`, it means that it supports `p2p-circuit` | ||
// this is avoided from the ENR to save space | ||
// we should add it | ||
if (ma.toString().includes("/p2p/")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should handle particular case because to me it seems possible to accidentally get p2p/p2p-circuit
or something.
if (hasP2p && isPeerId(left) && isPeerId(right)) {
...
}
Correct me here if I am wrong.
multiaddrs.push(multiaddr(multiaddrBytes)); | ||
let ma = multiaddr(multiaddrBytes); | ||
|
||
// if the multiaddr contains `p2p`, it means that it supports `p2p-circuit` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide the full explanation as referred in the description of the PR (that p2p-circuit
is not encoded due to space constraint in the ENR, in what form are multiaddr encoded and what is the valid final form of the multiaddr).
moving to draft until we investigate more on how to handle p2p-circuit relay better with js-waku |
posting not to forget: |
superseded by #1619 |
#1527 (comment)