-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to libp2p v2 #2143
Open
danisharora099
wants to merge
13
commits into
master
Choose a base branch
from
chore/libp2p-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
danisharora099
force-pushed
the
chore/libp2p-v2
branch
2 times, most recently
from
October 8, 2024 07:15
a1c3f08
to
7c5382f
Compare
danisharora099
force-pushed
the
chore/libp2p-v2
branch
from
October 9, 2024 05:30
7c5382f
to
279d952
Compare
danisharora099
force-pushed
the
chore/libp2p-v2
branch
2 times, most recently
from
October 10, 2024 10:20
22b146c
to
2b372ce
Compare
@danisharora099 did you try dogfooding it? I haven't but I'd like to have it done in various contexts before we merge Contexts to check:
Let's do this on Monday and if nothing caught - we can merge. |
danisharora099
force-pushed
the
chore/libp2p-v2
branch
from
October 14, 2024 07:59
dbc2ff6
to
7d85d36
Compare
danisharora099
force-pushed
the
chore/libp2p-v2
branch
2 times, most recently
from
October 16, 2024 12:19
cb48592
to
c3edbec
Compare
danisharora099
force-pushed
the
chore/libp2p-v2
branch
from
October 16, 2024 12:27
5cd0bab
to
f316ea7
Compare
weboko
reviewed
Oct 16, 2024
enr = await EnrCreator.fromPeerId(peerId); | ||
privateKey = await getPrivateKeyFromPeerId(peerId); | ||
console.log(enr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
console.log(enr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades from libp2p 1.x to libp2p v2
Migration notes: https://github.com/libp2p/js-libp2p/blob/main/doc/migrations/v1.0.0-v2.0.0.md#the-libp2ppeer-id-factory-module-has-been-removed