Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace app icon #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Replace app icon #645

wants to merge 1 commit into from

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented Oct 29, 2017

Icons with padding.

As I mentioned earlier, some icons have problems with aliasing.

@lokesh-krishna
Copy link
Contributor

Yay! So glad you're working on this. Should I close #638 in favor of this?

@ngosang
Copy link
Contributor

ngosang commented Mar 3, 2018

Tested in Android 7.0. It looks good but I don't like the padding around the icon (in my xiaomi is white around the grey icon).

@lokesh-krishna
Copy link
Contributor

@ngosang Could you please test the icon provided in #638?

@ngosang
Copy link
Contributor

ngosang commented Mar 3, 2018

I did and now I don't have a clear mind about that...
screenshot_2018-03-03-20-23-42-631_com miui home
screenshot_2018-03-03-16-21-07-306_com miui home

@ngosang
Copy link
Contributor

ngosang commented Mar 10, 2018

I would love this PR merged with the padding. Debug icons??

@Strubbl
Copy link
Contributor

Strubbl commented Mar 11, 2018

@lokesh-krishna would it be possible for you to add a debug icon and create a PR against the branch test_icons ?

@ all: What was the decision, which icons we use? Does Android documentation have a recommendation in this regard? Ones with padding or without?

@lokesh-krishna
Copy link
Contributor

lokesh-krishna commented Mar 13, 2018

@Strubbl, I've provided a debug icon at #638. Will that PR not suffice? I will gladly make one against the branch you mentioned if that is the case.

Information regarding padding for product icons can be found here: Material Design Guidelines.

The relevant information is in the section titled "DP unit grid". I am not sure I understood it though so it would be nice if someone could go through it and explain what exactly it is saying. Also, there is mention of padding in the document regarding Implementing Adaptive Icons. The content I am talking about is at the very end of the page, in the "Known Issues" section. Does that apply to us and even if it doesn't presently, is it something we should be taking into consideration when it comes to padding?

@ngosang
Copy link
Contributor

ngosang commented Mar 24, 2018

I prefer without padding, but it's only my opinion.

@lokesh-krishna
Copy link
Contributor

Seeing how we could go with either, opinions are all that matter. Would love to somehow see what the consensus and merge one of them.

@ngosang
Copy link
Contributor

ngosang commented Jun 6, 2019

are we waiting for something?

@techexo
Copy link
Contributor

techexo commented Aug 26, 2019

I prefer the one without padding, which should integrate more easily in a multitude of launchers and custom icons pack. But I agree that either way this should be merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants