feat: Allow overriding prebid mediaTypes #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch
We might not always want to have the same sizes config set in GPT and prebid. This change uses the old method by default, but allows you to override the
mediaTypes
object in the prebid config.E.g:
Verify
Confirm that cross browser testing has been completed.
Verify that no errors are present in the GPT console
window.googletag.openConsole()
.Comments
Love using ArcAds so far, great work!