Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAPPS-2465: updating packages in dockerfile for wiz fix #117

Merged
merged 1 commit into from
Nov 20, 2023
Merged

NAPPS-2465: updating packages in dockerfile for wiz fix #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ FROM public.ecr.aws/docker/library/ruby:2.7.7
# Throw errors if Gemfile has been modified since Gemfile.lock
RUN bundle config --global frozen 1

# Updating packages
RUN apt update && apt upgrade -yqq
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakekara do we want to say apt-get over apt across projects now? https://github.com/WPMedia/policeshootings/pull/592#pullrequestreview-1727678201

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whichever works. Depends on the OS the base image is using which tools are installed. In this case, apt is fine.


# Set up the app directory
WORKDIR /usr/src/app

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ FROM public.ecr.aws/docker/library/ruby:2.7.7
ARG USE_CRON=false
ENV USE_CRON=${USE_CRON}

# Install cron
RUN apt-get -y update && apt-get install -y cron
# Update packages and install cron
RUN apt -y update && apt upgrade -yqq && apt install -y cron
# Create the log file to be able to store logs
RUN touch /var/log/cron.log
# Cron (at least in Debian) does not execute crontabs with more than 1 hardlink, see bug 647193.
Expand Down