Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved: run CI workflow only when code inside waspc/ changes #1485

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

suyog-patil-21
Copy link
Contributor

Description

Fix Haskell CI workflow only when code inside waspc/ changes (Fixes #291).

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

@infomiho
Copy link
Contributor

@suyog-patil-21 do you know why did it run for this PR?

@suyog-patil-21
Copy link
Contributor Author

As GitHub Action workflow was changed. this PR required a approval to run.
So on the Maintainers console there is a button "Approve and Run".
So When the Maintainer approved it that why this PR's WASPC-CI workflow. ran.

@suyog-patil-21
Copy link
Contributor Author

I just noticed that this workflow will not work for on pull_request event. I will fix this. Please do not merge this PR.

@suyog-patil-21
Copy link
Contributor Author

I have fix the on pull_request event. You can now merge this PR

@Martinsos
Copy link
Member

@suyog-patil-21 looking good!
I wonder if we could easily test this. I will create two dummy PRs to see how this behaves.

@Martinsos
Copy link
Member

Nice job @suyog-patil-21 , works good, merging!

@Martinsos Martinsos merged commit adf37c1 into wasp-lang:main Oct 25, 2023
@suyog-patil-21 suyog-patil-21 deleted the fix-ci-workflow branch October 29, 2023 17:22
Martinsos pushed a commit that referenced this pull request Nov 17, 2023
* chore: run CI worklow only when code inside waspc/ changes

* fix: on pull_request event for run CI worklow only when code inside waspc/ changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Haskell CI worklow only when code inside waspc/ changes
3 participants