-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Swap wasp.png to wasp.svg #1538
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -903,7 +903,7 @@ This was the file tree of a newly generated project in the previous version of W | |
│ ├── Main.css | ||
│ ├── MainPage.js | ||
│ ├── .waspignore | ||
│ └── waspLogo.png | ||
│ └── waspLogo.svg | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't be changed, this and the line below, since this is ChangeLog -> so this is how it was at that point in the time and should be kept that way. |
||
├── .gitignore | ||
├── main.wasp | ||
└── .wasproot | ||
|
@@ -920,7 +920,7 @@ get by running `wasp new project` from this point onwards): | |
│ │ ├── MainPage.jsx | ||
│ │ ├── react-app-env.d.ts | ||
│ │ ├── tsconfig.json | ||
│ │ └── waspLogo.png | ||
│ │ └── waspLogo.svg | ||
│ ├── server | ||
│ │ └── tsconfig.json | ||
│ ├── shared | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import waspLogo from './waspLogo.png' | ||
import waspLogo from './waspLogo.svg' | ||
import './Main.css' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is really one of the most important changes, this change here. |
||
|
||
const MainPage = () => { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ This will generate a project skeleton in the folder `myApp`. The project structu | |
│ │ ├── MainPage.jsx | ||
│ │ ├── react-app-env.d.ts | ||
│ │ ├── tsconfig.json | ||
│ │ └── waspLogo.png | ||
│ │ └── waspLogo.svg | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Old blog post, so let's keep it as it was. |
||
│ ├── server # Your server code (Node JS) goes here. | ||
│ │ └── tsconfig.json | ||
│ ├── shared # Your shared (runtime independent) code goes here. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1104,7 +1104,7 @@ Ok, but what good is a function that fetches the data if we’ve got nowhere to | |
Let’s go now to our `src/client/MainPage.tsx` file (make sure it’s got the `.tsx` extension and not `.jsx`) and replace the contents with these below: | ||
|
||
```tsx | ||
import waspLogo from './waspLogo.png' | ||
import waspLogo from './waspLogo.svg' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also old blog post, let's keep it as it was. |
||
import './Main.css' | ||
|
||
const MainPage = () => { | ||
|
@@ -1208,7 +1208,7 @@ Next, we want our page to perform the following actions: | |
That’s exactly what the below code will do. Go ahead and replace the `MainPage` with it and take a minute to review what’s going on: | ||
|
||
```tsx | ||
import waspLogo from './waspLogo.png'; | ||
import waspLogo from './waspLogo.svg'; | ||
import './Main.css'; | ||
import { useState } from 'react'; | ||
import generateNewIdeas from '@wasp/actions/generateNewIdeas'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes you did in examples -> they are not really needed. It doesn't really matter if they use waspLogo.png, it is just a file generated at start. So I would revert these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, most of the example you corrected only half way -> you changed the import, but didn't swap .png file with .svg file. You did that in only one example. So I believe only one example works correctly.