Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Mailgun SDK + EU host support #2303

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Official Mailgun SDK + EU host support #2303

merged 3 commits into from
Sep 25, 2024

Conversation

infomiho
Copy link
Contributor

@infomiho infomiho commented Sep 24, 2024

Closes #2272

This PR:

  • uses the official Mailgun SDK (we didn't use it before because it didn't have Typescript support)
  • adds a new env var MAILGUN_API_URL to allows users to set their API url to the EU variant if they need

Left to do

  • Update docs

@infomiho infomiho marked this pull request as ready for review September 24, 2024 12:46
Signed-off-by: Mihovil Ilakovac <[email protected]>
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Martinsos
Copy link
Member

TODO: Update ChangeLog?

@infomiho
Copy link
Contributor Author

I'll update the Changelog in #2301

@infomiho infomiho merged commit d092fef into main Sep 25, 2024
6 checks passed
@infomiho infomiho deleted the miho-mailgun-eu branch September 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with using Mailgun and EU region
2 participants