Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace binlogIO with io.BinlogIO in datanode #14

Open
wants to merge 303 commits into
base: master
Choose a base branch
from
Open
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    9c8fd5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73cfdab View commit details
    Browse the repository at this point in the history
  3. enhance: make Load process traceable in querynode & segcore (milvus-i…

    …o#29858)
    
    See also milvus-io#29803
    
    This PR:
    - Add trace span for `LoadIndex` & `LoadFieldData` in segment loader
    - Add `TraceCtx` parameter for `Index.Load` in segcore
    - Add span for ReadFiles & Engine Load for Memory/Disk Vector index
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d642993 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. feat: support mmap for marisa trie (milvus-io#29613)

    this supports mmap for marisa trie index
    related milvus-io#21866
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    031243f View commit details
    Browse the repository at this point in the history
  2. fix: increase expr recursion depth to avoid parse failed (milvus-io#2…

    …9860)
    
    milvus-io#29759
    
    Signed-off-by: luzhang <[email protected]>
    Co-authored-by: luzhang <[email protected]>
    zhagnlu and luzhang authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5164d30 View commit details
    Browse the repository at this point in the history
  3. enhance: optimize search performance of inverted index (milvus-io#29794)

    issue: milvus-io#29793 
    Use `DocSetCollector` instead of `TopDocsCollector`, which will avoid
    scoring and sorting.
    
    ---------
    
    Signed-off-by: longjiquan <[email protected]>
    longjiquan authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    67ab5be View commit details
    Browse the repository at this point in the history
  4. enhance: skip loading duplicated index (milvus-io#29715)

    this protect the loading index from failure, and speed up the loading
    progress
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    44fe06f View commit details
    Browse the repository at this point in the history
  5. fix: Drop segment meta info with prefix (milvus-io#29856)

    If segment has more than 128 log fils, drop segment will exceed etcd txn
    ops limit, which will failed the drop segment request
    This PR drop segment meta info with prefix, to avoid drop segment meta
    failed
    
    ---------
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9fc5f11 View commit details
    Browse the repository at this point in the history
  6. fix: remove Unnecessary lock in config manager (milvus-io#29836)

    issue: milvus-io#29709 #291712
    to avoid concurrent recursive RLock and Lock cause deadlock, This PR
    remove the unnecessary lock in config manager
    
    ---------
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1f75983 View commit details
    Browse the repository at this point in the history
  7. enhance: Simplify cross cluster routing integration test (milvus-io#2…

    …9873)
    
    This pull request simplifies the integration test for cross-cluster
    routing by reusing `integration.MiniClusterSuite`, instead of defining
    custom Milvus clients, servers, and etcd client.
    
    issue: milvus-io#29874
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a4f15f4 View commit details
    Browse the repository at this point in the history
  8. fix: the insert count is zero after set the pointer to nil (milvus-io…

    …#29870)
    
    this leads to the EntitiesNum metric would be never reduced
    
    fix: milvus-io#29766
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    26e9001 View commit details
    Browse the repository at this point in the history
  9. Add float16 approve for multi-type part (milvus-io#28427)

    issue:milvus-io#22837
    
    Add bfloat16 vector, add the index part of float16 vector.
    
    Signed-off-by: Writer-X <[email protected]>
    Writer-X authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e429965 View commit details
    Browse the repository at this point in the history
  10. fix: Add multi logical exprs case (milvus-io#29871)

    milvus-io#29759
    
    Signed-off-by: luzhang <[email protected]>
    Co-authored-by: luzhang <[email protected]>
    zhagnlu and luzhang authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    673f980 View commit details
    Browse the repository at this point in the history
  11. enhance: Change some frequency log to rated level (milvus-io#29720)

    This PR change some frequency log to rated level
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7978479 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    27992e1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0b3b753 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1df3f90 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    930735c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. test: remove xfail from case (milvus-io#29853)

    pr: milvus-io#29634 
    
    After verifying that the problem is fixed, it is necessary to run this
    case every night for regression.
    
    Signed-off-by: elstic <[email protected]>
    elstic authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    315d492 View commit details
    Browse the repository at this point in the history
  2. [automated] Update Pytest image changes (milvus-io#29895)

    Update Pytest image changes
    See changes:
    milvus-io@930735c
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    0d39591 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90984a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    61acda4 View commit details
    Browse the repository at this point in the history
  5. [automated] Update Knowhere Commit (milvus-io#29904)

    Update Knowhere Commit
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    4d11525 View commit details
    Browse the repository at this point in the history
  6. enhance: add trace span for wait tsafe (milvus-io#29911)

    Add tracing span for search/query operation waiting tsafe duration
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    adf0c88 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    aba2656 View commit details
    Browse the repository at this point in the history
  8. enhance: optimize the loading strategy (milvus-io#29910)

    as we have the pool size limit so we don't need to limit the concurrency
    manually
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    6c477ce View commit details
    Browse the repository at this point in the history
  9. enhance: reduce delete detail log to delete range (milvus-io#29916)

    Delete detail log will be large and hard to read when log level is
    debug. This PR change the log to stringer and print only pk range,
    number.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    1062269 View commit details
    Browse the repository at this point in the history
  10. enhance: correct nightly e2e (milvus-io#29919)

    Signed-off-by: Sammy Huang <[email protected]>
    yellow-shine authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d3dd2a2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a442194 View commit details
    Browse the repository at this point in the history
  12. enhance: optimize the loading index performance (milvus-io#29894)

    this utilizes concurrent loading
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    f2e36db View commit details
    Browse the repository at this point in the history
  13. feat: integrate storagev2 into loading segment (milvus-io#29336)

    issue: milvus-io#29335
    
    ---------
    
    Signed-off-by: sunby <[email protected]>
    sunby authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    e1258b8 View commit details
    Browse the repository at this point in the history
  14. enhance: Skip generate load segment task (milvus-io#29724)

    issue: milvus-io#29814
    if channel is not subscribed yet, the generated load segment task will
    be remove from task scheduler due to the load segment task need to be
    transfer to worker node by shard leader.
    
    This PR skip generate load segment task when channel is not subscribed
    yet.
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    565fc3a View commit details
    Browse the repository at this point in the history
  15. fix: Fix error message for indexing (milvus-io#29898)

    issue: milvus-io#29897
    
    ---------
    
    Signed-off-by: Cai Zhang <[email protected]>
    xiaocai2333 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8c89ad6 View commit details
    Browse the repository at this point in the history
  16. enhance: Add a group by case (milvus-io#29939)

    Related issue: milvus-io#29883 
    xfail for now.
    
    Signed-off-by: yanliang567 <[email protected]>
    yanliang567 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    c1b0562 View commit details
    Browse the repository at this point in the history
  17. enhance: make compactor use actual buffer size to decide when to sync (

    …milvus-io#29945)
    
    See also: milvus-io#29657
    
    Datanode Compactor use estimated row number from schema to decide when
    to sync the batch of data when executing compaction. This est value
    could go way from actual size when the schema contains variable field(
    say VarChar, JSON, etc.)
    
    This PR make compactor able to check the actual buffer data size and
    make it possible to sync when buffer is actually beyong max binglog
    size.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    ed89c6a View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. enhance: Use newer checkpoint when packing LoadSegmentRequest (milvus…

    …-io#29922)
    
    See also: milvus-io#29650
    
    Either segment dml position & channel checkpoint could be newer in some
    cases. This PR make PackLoadSegments use the newer one improving load
    performance during cases where there are lots of upsert.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 13, 2024
    Configuration menu
    Copy the full SHA
    082ee1a View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. enhance: change some frequent log level (milvus-io#29953)

    Signed-off-by: lixinguo <[email protected]>
    Co-authored-by: lixinguo <[email protected]>
    smellthemoon and lixinguo authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    595ec25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d300bc7 View commit details
    Browse the repository at this point in the history
  3. fix: remove checking if running inside container (milvus-io#29940)

    issue: milvus-io#29846
    
    Since checking if Milvus running inside the container is difficult,
    which is decided by the system version and cgroup version, we try to get
    the memory limit of the container each time instead of checking whether
    inside the container first.
    
    Signed-off-by: jaime <[email protected]>
    jaime0815 authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    ee26561 View commit details
    Browse the repository at this point in the history
  4. fix: the delete msg disorder issue (milvus-io#29915)

    /kind improvement
    
    Signed-off-by: SimFG <[email protected]>
    SimFG authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    d9edd50 View commit details
    Browse the repository at this point in the history
  5. fix: SealedIndexingEntry in SealedIndexingRecord may leak without sma…

    …rt pointer protect. (milvus-io#29932)
    
    may related issue: milvus-io#29828
    
    Signed-off-by: chyezh <[email protected]>
    chyezh authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    def717a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    df5445f View commit details
    Browse the repository at this point in the history
  7. enhance:remove some unused code (milvus-io#29827)

    Signed-off-by: lixinguo <[email protected]>
    Co-authored-by: lixinguo <[email protected]>
    smellthemoon and lixinguo authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    073de85 View commit details
    Browse the repository at this point in the history
  8. fix: Fix unstable msg dispatcher ut (milvus-io#29925)

    This fix will not augment the execution time of unit tests, but solely
    enhances tolerance for waiting for failure.
    
    issue: milvus-io#29921
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    8febbc7 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. fix: Dynamic update rate limit config with wrong value (milvus-io#29901)

    when apply dynamic config changes, we should format the value to proper
    unit
    This PR fix update rate limit config with wrong value.
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    fb4fbcf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9508a4 View commit details
    Browse the repository at this point in the history
  3. enhance: refine groupby-performance (milvus-io#29933)

    related: milvus-io#29844
    
    Signed-off-by: MrPresent-Han <[email protected]>
    MrPresent-Han authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c31e684 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    8030b90 View commit details
    Browse the repository at this point in the history
  2. enhance: adjust the GPU pool size (milvus-io#29937)

    according to benchmark, the GPU pool size with 6 performs best
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    cda44c0 View commit details
    Browse the repository at this point in the history
  3. enhance: [skip e2e] use checkout action to get ".git" for codecov (mi…

    …lvus-io#30014)
    
    Ignoring .git may result "unusable report" in codecov. Use checkout
    action to get .git information in upload codecov step
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2dacca7 View commit details
    Browse the repository at this point in the history
  4. fix: level 0 segments not loaded (milvus-io#29908)

    the recent changes move the level 0 segments list to a new proto field,
    which leads to the QueryCoord can't see the level 0 segments, handle the
    new changes
    fix milvus-io#29907
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c68c128 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    750166f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a0eb1d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7cb6beb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c0f0548 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    7f059b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad7a0b4 View commit details
    Browse the repository at this point in the history
  3. fix: Remove heartbeat lag logic during get shard leaders (milvus-io#2…

    …9999)
    
    issue: milvus-io#29677 milvus-io#29838
    during get shard leaders, if qeurynode doesn't ack the heartbeat than
    10s, querycoord will treat it as unavailable, and won't return shard
    leader on it. but when querynode has a full cpu usage, it's easily to
    stuck for more than 10s without ack the heartbeat, which cause no shard
    leader to search/query.
    
    This PR remove heartbeat lag logic during get shard leaders
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9abc868 View commit details
    Browse the repository at this point in the history
  4. enhance: enable converting segcore error to merr (milvus-io#29914)

    this converts the segcore error to merr if possible
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8f083e4 View commit details
    Browse the repository at this point in the history
  5. enhance: add index after load succeeded (milvus-io#30015)

    this avoids a corner case: after load index failed, this index can be
    never loaded as it has been added into the segment's index map
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9a38372 View commit details
    Browse the repository at this point in the history
  6. enhance: free CString in InitTraceConfig (milvus-io#30055)

    `C.CString` result needs to be freed after usage
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    10acdbb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1152838 View commit details
    Browse the repository at this point in the history
  8. enhance: [skip e2e]to workaround the error "HOME not set" (milvus-io#…

    …30047)
    
    issue: milvus-io#30046
    
    to workaround the error "HOME not set"  happened in self hosted runner
    
    solution from
    https://alexanderhose.com/aws-codecommit-with-instance-role-and-user-data/
    
    Signed-off-by: Sammy Huang <[email protected]>
    yellow-shine authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e7dc82d View commit details
    Browse the repository at this point in the history
  9. fix: report error if the altering index doesn't support mmap (milvus-…

    …io#29832)
    
    this also checks the param value
    fix milvus-io#29909
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1c8ce33 View commit details
    Browse the repository at this point in the history
  10. fix: written file size is over the int32 range and raises error (milv…

    …us-io#30057)
    
    we sum the total data size in int32, which could lead to an overflow
    error
    related milvus-io#30056
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1185e4d View commit details
    Browse the repository at this point in the history
  11. enhance: change some important request log level to Info (milvus-io#3…

    …0062)
    
    Some important request log level shall be at least Info level
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    80465a0 View commit details
    Browse the repository at this point in the history
  12. fix: duplicate dynamic field data by mistake (milvus-io#30042)

    issue : milvus-io#30000
    
    Signed-off-by: zhenshan.cao <[email protected]>
    czs007 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3174044 View commit details
    Browse the repository at this point in the history
  13. fix: Leader checker canot submit load task (milvus-io#30067)

    issue: milvus-io#29841
    if segment loaded, submit load segment task for it isn't permitted, to
    avoid load segment twice. but this logic blocks the leader checker to
    correct leader view by `LoadSegment`
    
    This PR remove the segment loaded check, to fix that leader checker
    cann't submit load task
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    57bd3e2 View commit details
    Browse the repository at this point in the history
  14. enhance: delete should inc ProxyFunctionCall metric failed label when…

    … run failed instead abandon (milvus-io#29621)
    
    Signed-off-by: aoiasd <[email protected]>
    aoiasd authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    04e2156 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4c93912 View commit details
    Browse the repository at this point in the history
  16. fix: Trigger leader checker too frequency (milvus-io#29991)

    issue: milvus-io#29841
    This PR fix leader checker use wrong check interval, which causes leader
    checker trigger too frequency
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f8695ae View commit details
    Browse the repository at this point in the history
  17. Update all contributors

    Signed-off-by: sre-ci-robot <[email protected]>
    sre-ci-robot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6fd4325 View commit details
    Browse the repository at this point in the history
  18. enhance: Opt metric type does not match error message (milvus-io#29927)

    issue: milvus-io#29791 
    /kind improvement
    Signed-off-by: xige-16 <[email protected]>
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fa7cf58 View commit details
    Browse the repository at this point in the history
  19. fix: Add more checks to rank params (milvus-io#29950)

    issue: milvus-io#29840 milvus-io#29867
    /kind bug
    
    Signed-off-by: xige-16 <[email protected]>
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    91aa81b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    0d4e781 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. enhance: make integration test case timeout configurable (milvus-io#3…

    …0073)
    
    currently integration test may timeout if any case run time is above 3
    minutes. This duration was hard coded.
    
    This PR change this duration into a customized parameter and could be
    passed via test running commands.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9f8eb0e View commit details
    Browse the repository at this point in the history
  2. fix: CollectionSchema.autoID is deprecated (milvus-io#30002)

    issue: milvus-io#30000
    related to: [milvus-proto
    milvus-io#202](milvus-io/milvus-proto#202)
    
    1. replace collSchema.AutoID with primaryField.AutoID
    2. show `enableDynamic` & `enableDynamicField` at the same time
    3. avoid data race about the access to metacache
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    631ebb1 View commit details
    Browse the repository at this point in the history
  3. test: update pyarrow version (milvus-io#29992)

    fix vulnerability alerts
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c91254f View commit details
    Browse the repository at this point in the history
  4. fix: Proxy restful api doesn't register (milvus-io#30072)

    issue: milvus-io#30074
    This PR fix that management restful api in proxy doesn't register to
    http service
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    fc56ed5 View commit details
    Browse the repository at this point in the history
  5. enhance:don't store logPath in meta to reduce memory (milvus-io#28873)

    don't store logPath in meta to reduce memory, when service get
    segmentinfo, generate logpath from logid.
    milvus-io#28885
    
    Signed-off-by: lixinguo <[email protected]>
    Co-authored-by: lixinguo <[email protected]>
    smellthemoon and lixinguo authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e52ce37 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ddccccb View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. fix: Add more throughput in related metrics (milvus-io#30038)

    This PR also fixes bugs in l0 compactor where
    l0 results would never be removed from datanode
    
    See also: milvus-io#30099
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    86f4886 View commit details
    Browse the repository at this point in the history
  2. fix: fix wrong log file name when running as mixture type (milvus-io#…

    …29979)
    
    See also: milvus-io#25323, milvus-io#29969
    many users reported log file name is incorrect when starting in mixture
    type.
    
    ---------
    
    Signed-off-by: sunby <[email protected]>
    sunby authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    dad27cb View commit details
    Browse the repository at this point in the history
  3. enhance: calc the accurate mem size of segment (milvus-io#30093)

    this stats the real memory size of segment, also reduces the memory
    usage in mmap mode
    resolve milvus-io#30095
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f542bdb View commit details
    Browse the repository at this point in the history
  4. fix: Move compress binlog after check result GetCompactionResult error (

    milvus-io#30127)
    
    See also: milvus-io#28873
    
    When datanode returns error or go offline during GetCompactionResult
    call, the compress binlog logic will panic since it was using a nil
    result
    
    This PR move it after the CheckRPCCall error to prevent this case.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    15716ec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4ef6217 View commit details
    Browse the repository at this point in the history
  6. enhance: only buffer delete if it match insert has smaller timestamp (m…

    …ilvus-io#30122)
    
    See also: milvus-io#30121 milvus-io#27675
    
    This PR changes the delete buffering logic:
    - Write buffer shall buffer insert first
    - Then the delete messages shall be evaluated
      - Whether PK matches previous Bloom filter, which ts is always smaller
      - Whether PK matches insert data which has smaller timestamp
    - Then the segment bloom filter is updates by the newly buffered pk rows
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0d356b0 View commit details
    Browse the repository at this point in the history
  7. enhance: Opt vector dimension mismatch error message (milvus-io#29928)

    issue: milvus-io#29791
    /kind improvement
    
    Signed-off-by: xige-16 <[email protected]>
    
    ---------
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    aee19dc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3d46096 View commit details
    Browse the repository at this point in the history
  9. test: add test cases (milvus-io#29924)

    issue: milvus-io#28499
    
    Signed-off-by: nico <[email protected]>
    NicoYuan1986 authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ba0e980 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a762561 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d802517 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ddd741a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e3b8c3f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. fix: Leader checker can't remove segment from leader view (milvus-io#…

    …30151)
    
    issue: milvus-io#30150
    
    This PR fix three problems:
    1. leader checker use wrong node id when generate release task, which
    cause the release task finished immediately
    2. the release request generated by leader_checker doesn't set the
    `force` flag, the operation to clean leader view on delegator will fail.
    
    Signed-off-by: Wei Liu <[email protected]>
    weiliu1031 authored Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f69f65f View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. enhance: support dataType: array & json (milvus-io#30076)

    issue: milvus-io#30075
    
    deal with the array<?> field data correctly
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    4f44942 View commit details
    Browse the repository at this point in the history
  2. enhance: Add a counter monitoring for the rate-limit requests (milvus…

    …-io#30109)
    
    Add a counter monitoring metric for the ratelimited rpc requests with
    labels: proxy nodeID, rpc request type, and state.
    
    issue: milvus-io#30052
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    c8a7846 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    8a6bc2a View commit details
    Browse the repository at this point in the history
  2. [automated] Update Pytest image changes (milvus-io#30104)

    Update Pytest image changes
    See changes:
    milvus-io@c91254f
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    922414c View commit details
    Browse the repository at this point in the history
  3. enhance: [skip e2e]Revert changes from pr 29890 (milvus-io#29957)

    Revert changes from pr milvus-io#29890
    
    This reverts commit 61acda4.
    
    Signed-off-by: Sammy Huang <[email protected]>
    yellow-shine authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ae4f62a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4436eff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a81d2b4 View commit details
    Browse the repository at this point in the history
  6. fix: Use channel cp as the dml&start position for import segments (mi…

    …lvus-io#30107)
    
    This PR discontinuing the subscription to the mq and, instead, employing
    the channel checkpoint as the DML and starting position for the import
    segments.
    
    issue: milvus-io#30106
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8780d65 View commit details
    Browse the repository at this point in the history
  7. fix: decompress deltelog path for level zero compaction (milvus-io#30164

    )
    
    Resolves: milvus-io#30161
    See also: milvus-io#28873
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8a6de3d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5ee9f73 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6bfa826 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4142743 View commit details
    Browse the repository at this point in the history
  11. [automated] Update Knowhere Commit (milvus-io#30120)

    Update Knowhere Commit
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e967949 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0ac37a4 View commit details
    Browse the repository at this point in the history
  13. enhance: convert the GetObject util to async (milvus-io#30166)

    This makes it much easier to use
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a77693a View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Update all contributors

    Signed-off-by: sre-ci-robot <[email protected]>
    sre-ci-robot committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3d31017 View commit details
    Browse the repository at this point in the history
  2. enhance: Add open telemetry tracing for compaction (milvus-io#30168)

    Resolves milvus-io#30167
    
    This PR add tracing for all compaction from the task start in datacoord
    and execution procedures in datanode.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6a73860 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6cf2f09 View commit details
    Browse the repository at this point in the history
  4. fix:diskann search crash when search list = 9999999999 (milvus-io#30185)

    issue: milvus-io#29020
    Json can't not pass a max_int32 value to int32_t, so let knowhere check
    value range by itself.
    After fix this, pymilvus will report:
    pymilvus.exceptions.MilvusException: <MilvusException: (code=65535,
    message=fail to search on QueryNode 6: worker(6) query failed: => failed
    to search: arithmetic overflow: param search_list_size should be at most
    2147483647)>
    
    Signed-off-by: cqy123456 <[email protected]>
    cqy123456 authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    42bb4e3 View commit details
    Browse the repository at this point in the history
  5. enhance: support related privilege for grant api (milvus-io#30153)

    /kind improvement
    
    Signed-off-by: SimFG <[email protected]>
    SimFG authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4637659 View commit details
    Browse the repository at this point in the history
  6. test: add assert message if assert failed (milvus-io#30186)

    add assert message if assert failed
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    24bbb12 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d73b534 View commit details
    Browse the repository at this point in the history
  8. fix: Init paramtable after milvus role setup (milvus-io#30211)

    See also milvus-io#30176
    
    Move paramtable.Init after env setup in roles.Run. Also introduced a
    flag for mixture run to set role correctly for mixture mode.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c9860e3 View commit details
    Browse the repository at this point in the history
  9. test: add restful client test in ci (milvus-io#30036)

    add restful client test in ci
    
    ---------
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cad8bf6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    38746df View commit details
    Browse the repository at this point in the history
  11. enhance: pass partition key scalar info if enabled when build vector …

    …index (milvus-io#29931)
    
    issue: milvus-io#29892 
    
    Pass optional scalar IVF offsets to Cardinal
    
    Signed-off-by: Patrick Weizhi Xu <[email protected]>
    PwzXxm authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0907d76 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. fix: wrong format expr for the delete rest api (milvus-io#30217)

    /kind improvement
    issue: milvus-io#30092
    
    Signed-off-by: SimFG <[email protected]>
    SimFG authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b62748a View commit details
    Browse the repository at this point in the history
  2. feat: support etcd authentication (milvus-io#30226)

    issue: milvus-io#28895
    add 3 configuration for ETCD config
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    08ca0a2 View commit details
    Browse the repository at this point in the history
  3. fix: prevent segments got flushed multiple times (milvus-io#30240)

    See also milvus-io#30111
    
    Segments could be "Flushed" only by `FlushSegments` grpc call from
    datacoord by design. There are two possible reason to cause one segment
    got flushed multiple times.
    
    - Segment is in flushing state during multiple epoch in flowgraph
    - Segment is flushed by flushTs & Flush segments
    
    So this pr fix:
    
    - Remove state change logic form FlushTs policy
    - Change Flush segment into three stage way: Sealed->Flushing->Flushed
    preventing multiple Flushed=true operations.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6445880 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    36b8fbb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3e741cc View commit details
    Browse the repository at this point in the history
  6. enhance: update pymilvus version and update cases (milvus-io#30012)

    1. modify test case: test_search_repeatedly_ivf_index_different_limit
    2. update pymilvus version from 2.4.0rc19 to 2.4.0rc24
    3. Before, insert will return a pk list. In the latest milvus client,
    insert will return a number that is inserted successfully
    4. In the latest milvus client, flush and num_entities have been removed
    5. Before, the default consistency level of a new collection is strong.
    In the latest milvus client, it becomes bounded. So related cases have
    been modified correspondingly, or immediate search after insert will
    return no results.
    6. In the latest pymilvus, new data type FLOAT16_VECTOR and
    BFLOAT16_VECTOR have been added.
    
    Signed-off-by: nico <[email protected]>
    NicoYuan1986 authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    ba862ef View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    8c58d9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da749c0 View commit details
    Browse the repository at this point in the history
  3. fix: Fix requery without limit during HybridSearch (milvus-io#30220)

    issue: milvus-io#29990 
    
    /kind bug
    
    Signed-off-by: xige-16 <[email protected]>
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4f25066 View commit details
    Browse the repository at this point in the history
  4. enhance: Utilize partition key optimization in reQuery (milvus-io#30253)

    See also milvus-io#30250
    
    This PR add requery flag in query task. When reQuery flag is true, query
    task shall skip partition name conversion and use pre-calculated
    partitionIDs passed from search task.
    
    TODO: hybrid search does not have partition id information. we shall
    apply same logic for hybrid search later.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8e8ac21 View commit details
    Browse the repository at this point in the history
  5. enhance: hint the invalid metric type in error message (milvus-io#30263)

    this hints the user passed invalid metric type in error message, so
    users could know what's wrong
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    51fe474 View commit details
    Browse the repository at this point in the history
  6. test: add multi vector for bulk insert test (milvus-io#30223)

    add multi vector for bulk insert test
    
    ---------
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    78562d0 View commit details
    Browse the repository at this point in the history
  7. enhance: move the cgo code in the pkg dir to interal dir (milvus-io#3…

    …0261)
    
    /kind improvement
    
    Signed-off-by: SimFG <[email protected]>
    SimFG authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    aa7014a View commit details
    Browse the repository at this point in the history
  8. enhance: reduce many I/O operations while loading disk index (milvus-…

    …io#30189)
    
    before this, every time writting the index chunk data into the disk,
    there are 4 I/O operations:
    - open the file
    - seek to the offset
    - write the data
    - close the file
    
    this optimized this to open only once and continiously write all data.
    
    This also makes it concurrent to load the files from object storage
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a27c0e8 View commit details
    Browse the repository at this point in the history
  9. Update README.md

    xiaofan-luan authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9488ac0 View commit details
    Browse the repository at this point in the history
  10. Update README.md

    xiaofan-luan authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ea44277 View commit details
    Browse the repository at this point in the history
  11. enhance: Add trace span for scheduling read tasks in QueryNode (milvu…

    …s-io#30265)
    
    This PR adds a trace span for search/query task scheduling duration
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f2c0ead View commit details
    Browse the repository at this point in the history
  12. enhance: Allows proactive warming up of chunk cache (milvus-io#30182)

    Allows proactive warming up of chunk cache. Original vector data will be
    asynchronously loaded into the chunk cache during the load process. It
    has the potential to significantly reduce query/search latency for a
    certain duration after the load, albeit with a concurrent increase in
    disk usage.
    
    issue: milvus-io#30181
    
    ---------
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c02fb64 View commit details
    Browse the repository at this point in the history
  13. fix: groupby bug for ut (milvus-io#30272)

    related: milvus-io#29965
    
    Signed-off-by: MrPresent-Han <[email protected]>
    MrPresent-Han authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    116d0f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    a847d56 View commit details
    Browse the repository at this point in the history
  2. fix: Use correct pools for all CGO methods in segments pkg (milvus-io…

    …#30274)
    
    See also milvus-io#30273
    
    This PR:
    - Rename confusing `LoadIndexInfo` to `UpdateIndexInfo` for LocalSegment
    - Use `DynamicPool` instead of `LoadPool` for `UpdateSealedSegmentIndex`
    - Fix cgo call missing pool control
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    405877c View commit details
    Browse the repository at this point in the history
  3. fix: Fill in info in CompactionSegmentBinlogs (milvus-io#30279)

    After milvus-io#28873, PartitionID and CollectionID should be filled in
    CompactionSegmentBinlog so that DataNode can compose
    the correct logPath. However There're some places left forgotten to fill
    in the information, causing Datanode downloading `xxx/0/0/xxxx/xxxx`
    binlogs during compaction
    
    See also: milvus-io#30213
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0b6beb7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fd19e41 View commit details
    Browse the repository at this point in the history
  5. fix: channel checker reduce balancing channels. (milvus-io#30087)

    Ignore leader unavailable when channel checker judge repeat channel to
    avoid channel checker remove channels balancing.
    relate: milvus-io#29841
    milvus-io#29838
    
    Signed-off-by: aoiasd <[email protected]>
    aoiasd authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f84d9a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    199c198 View commit details
    Browse the repository at this point in the history
  7. enhance: Enlarge default datanode sync parallel to 256 (milvus-io#30270)

    See also milvus-io#27675
    
    After supporting control sync parallel in datanode globally, the shall
    change default value to a more suitable value for most use cases.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7ced0af View commit details
    Browse the repository at this point in the history
  8. fix: fix searchPlan metricType modified concurrently (milvus-io#30227)

    issue: milvus-io#30225
    /kind bug
    Signed-off-by: xige-16 <[email protected]>
    
    ---------
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e9fdd24 View commit details
    Browse the repository at this point in the history
  9. enhance: Set correct role for non-standalone deployment (milvus-io#30303

    )
    
    See also milvus-io#30211
    
    After fix initialization problem, distributed components do no have
    their role set. This will cause logger & tracing miss component service
    info when recording information.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    20a3569 View commit details
    Browse the repository at this point in the history
  10. enhance: Don't expire ShardLeaders cache actively (milvus-io#29879)

    issue: milvus-io#29772 
    
    The shardLeaders cache does not actively expire, update the cache when
    search/query fails.
    
    Signed-off-by: Cai Zhang <[email protected]>
    xiaocai2333 authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d87726e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f2985d8 View commit details
    Browse the repository at this point in the history
  12. enhance: adjust config source for support config event use paramtable (

    …milvus-io#29995)
    
    Adjust config source for support config event which for dynamic config
    could use paramtable and not deadlock.
    relate: milvus-io#29807
    
    Signed-off-by: aoiasd <[email protected]>
    aoiasd authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8385157 View commit details
    Browse the repository at this point in the history
  13. Update all contributors

    Signed-off-by: sre-ci-robot <[email protected]>
    sre-ci-robot committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c3c9dcd View commit details
    Browse the repository at this point in the history
  14. enhance: reduce memory when read data (milvus-io#30284)

    Signed-off-by: lixinguo <[email protected]>
    Co-authored-by: lixinguo <[email protected]>
    smellthemoon and lixinguo authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9512af3 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. fix: empty MetricType (milvus-io#30216)

    issue: milvus-io#30102 milvus-io#30225
    
    we should read MetricType from SearchResult,
    because query node never
    1. read metricType from LoadMeta
    2. store to collection
    3. set SearchRequest.MetricType
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    8fc4ebf View commit details
    Browse the repository at this point in the history
  2. feat: restful phase two (milvus-io#29728)

    issue: milvus-io#29732
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    6abbab1 View commit details
    Browse the repository at this point in the history
  3. enhance: change plan desc log from info to debug (milvus-io#30304)

    milvus-io#30172
    
    Signed-off-by: luzhang <[email protected]>
    Co-authored-by: luzhang <[email protected]>
    zhagnlu and luzhang authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    aeb1e36 View commit details
    Browse the repository at this point in the history
  4. [automated] Update Knowhere Commit (milvus-io#30332)

    Update Knowhere Commit
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    0542a0e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    927d310 View commit details
    Browse the repository at this point in the history
  2. enhance: Set segment.maxSize param to 1024M (milvus-io#30139)

    issue: milvus-io#25639 
    /kind improvement
    
    When the number of vector columns increases, the number of rows per
    segment will decrease. In order to reduce the impact on vector indexing
    performance, it is necessary to increase the segment max limit.
    
    If a collection has multiple vector fields with memory and disk indices
    on different vector fields, the size limit after segment compaction is
    the minimum of segment.maxSize and segment.diskSegmentMaxSize.
    
    Signed-off-by: xige-16 <[email protected]>
    
    ---------
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    033eae9 View commit details
    Browse the repository at this point in the history
  3. test: add freshness checker (milvus-io#30280)

    add freshness checker
    
    insert/upsert --> query:  Get the time when it can be queried
    
    delete --> query: Get the time when it can not be queried
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    aab7cc9 View commit details
    Browse the repository at this point in the history
  4. test: [skip e2e]add values yaml file for one pod standalone chaos test (

    milvus-io#30311)
    
    add values yaml file for one pod standalone chaos test
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    467379d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    406bf14 View commit details
    Browse the repository at this point in the history
  6. test: add invert index and string datatype for bulk insert test (milv…

    …us-io#30334)
    
    add invert index and string datatype for bulk insert test
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fcd9f89 View commit details
    Browse the repository at this point in the history
  7. enhance: add basic information of milvus into metrics (milvus-io#29665)

    add basic build information and runtime component dependency into
    metrics.
    
    issue: milvus-io#29664
    
    Signed-off-by: chyezh <[email protected]>
    chyezh authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    211143c View commit details
    Browse the repository at this point in the history
  8. test: add milvus client test cases (milvus-io#30323)

    issue: milvus-io#30221
    
    Signed-off-by: binbin lv <[email protected]>
    binbinlv authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    f274c16 View commit details
    Browse the repository at this point in the history
  9. test: Update requirements and pytest configuration (milvus-io#30336)

    Update requirements and pytest configuration
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    f92edc6 View commit details
    Browse the repository at this point in the history
  10. enhance:limit binlog index rows num (milvus-io#30173)

    issue: milvus-io#27678
    also relate issue: milvus-io#30065
    
    Signed-off-by: cqy123456 <[email protected]>
    cqy123456 authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    74cfba0 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. enhance: Make l0 compactor download files in parallel (milvus-io#30309)

    See also milvus-io#27606
    
    `MultiRead` actually download file in sequence, which may lead to large
    time consumption during l0 compaction download phase.
    
    This PR make l0 compactor download deltalogs in parallel utilizing conc
    package & io pool.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    743bdf1 View commit details
    Browse the repository at this point in the history
  2. enhance: Make compaction log has traceID (milvus-io#30338)

    See also milvus-io#30167
    
    After support open telemetry tracing, we want to have traceID as well,
    this PR adds util functions to set traceID with span & propagate traceID
    between different context.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0c7a96b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c086a4 View commit details
    Browse the repository at this point in the history
  4. test: update test cases about rbac (milvus-io#29088)

    issue: milvus-io#29087
    RBAC cases fail a lot.
    1. some cases are out of date, for example, the default value of db_name
    has changed from "default" to "" in some apis
    2. add time sleep after the action of grant or revoke, for it costs time
    to take effect
    
    Signed-off-by: nico <[email protected]>
    NicoYuan1986 authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    168260c View commit details
    Browse the repository at this point in the history
  5. enhance: Break down the granularity of collection info cache expired (m…

    …ilvus-io#29977)
    
    issue: milvus-io#29772 
    
    1. `DropPartition` only invalidates the cache related to the partition.
    2. `CreateAlias` does not invalidate the cache.
    
    Signed-off-by: Cai Zhang <[email protected]>
    xiaocai2333 authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f619d79 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    47af347 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6d63fb5 View commit details
    Browse the repository at this point in the history
  8. enhance: hotfix docker-compose.yml (milvus-io#30378)

    Signed-off-by: Sammy Huang <[email protected]>
    yellow-shine authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    fda6f8d View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. enhance: hotfix container network (milvus-io#30389)

    Signed-off-by: Sammy Huang <[email protected]>
    yellow-shine authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    fb9d64a View commit details
    Browse the repository at this point in the history
  2. test: fix query result verification (milvus-io#30351)

    fix query result verification:
    changed the query expression and adopted a more lenient validation
    method to address the issue of not being able to guarantee the retrieval
    of specific IDs due to frequent deletion operation
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e6daff4 View commit details
    Browse the repository at this point in the history
  3. enhance: limit the max pool size to 16 (milvus-io#30371)

    according to our benchmark, concurrency level 16 is enough to fully
    utilize the object storage network bandwidth
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    878c4c9 View commit details
    Browse the repository at this point in the history
  4. enhance: Add more tests for groupby (milvus-io#30346)

    Related issue: milvus-io#30033
    skip the tests before bug fixes
    
    ---------
    
    Signed-off-by: yanliang567 <[email protected]>
    yanliang567 authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5415025 View commit details
    Browse the repository at this point in the history
  5. fix: proxy may never setup if the port binded (milvus-io#30035)

    the proxy miss-returned nil while failed to listen the port, then the
    server continues to run but we can't connect to service
    resolve milvus-io#30034
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2f778d9 View commit details
    Browse the repository at this point in the history
  6. enhance: restful support import jobs (milvus-io#30343)

    issue: milvus-io#28521 milvus-io#29732
    
    include
    1. list collection's import jobs
    2. create a new import job
    3. get the progress of an import job
    
    fix:
    1. mix the order of dbName & collectionName milvus-io#29728
    2. trace log keep the same as v1
    3. support traceID
    4. azure precheck, blob name cannot end with / milvus-io#29703
    
    ---------
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5cf9bb2 View commit details
    Browse the repository at this point in the history
  7. enhance: Remove current stats after RollStats action (milvus-io#30391)

    See also milvus-io#27675
    
    BloomFilterSet.current shall be reset after RollStats, otherwise it will
    keep tracking whole segment data causing the false positive ratio larger
    than expected.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b5e078c View commit details
    Browse the repository at this point in the history
  8. enhance: Add MemoryHighSyncPolicy back to write buffer manager (mil…

    …vus-io#29997)
    
    See also milvus-io#27675
    
    This PR adds back MemoryHighSyncPolicy implementation. Also change
    MinSegmentSize & CheckInterval to configurable param item.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    fc0d007 View commit details
    Browse the repository at this point in the history
  9. feat: Add import executor and manager for datanode (milvus-io#29438)

    This PR introduces novel importv2 roles for datanode:
    1. Executor: To execute tasks, a import task will be divided into the
    following steps: read data -> hash data -> sync data;
    2. Manager: To manage all the tasks;
    
    issue: milvus-io#28521
    
    ---------
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c591829 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. enhance: Add PrimaryKeys interface to reduce memory usage (milvus-io#…

    …30405)
    
    See also milvus-io#30404
    
    `PrimaryKey` is used to hold pk values for both int64 & varchar data
    type. Since it is an interface it may occupies more memory than pure
    slices when holding a group of pks.
    
    This PR add `PrimaryKeys` interface when some other module need to hold
    lots of PrimaryKeys.
    By using this interface, it could reduce the memory of pk slice to half
    when using Int64 Pk data type and reduce interface cost for each row of
    varchar as well.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e677af1 View commit details
    Browse the repository at this point in the history
  2. test: refine debug log and error handle (milvus-io#30406)

    refine debug log and error handle
    
    ---------
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b02b525 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    265453f View commit details
    Browse the repository at this point in the history
  4. enhance: Reduce get segments scan during l0 compaction (milvus-io#30408)

    See also milvus-io#27606
    
    Previously l0 linear compaction will scan all target segment id from
    metacache for each line of delta entry, which is not needed since
    compaction target segments shall be all immutable.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    be8831b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e0f371c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    46d9ac5 View commit details
    Browse the repository at this point in the history
  7. enhance: full-support for wildcard pattern matching (milvus-io#30288)

    issue: milvus-io#29988 
    This pr adds full-support for wildcard pattern matching from end to end.
    Before this pr, the users can only use prefix match in their expression,
    for example, "like 'prefix%'". With this pr, more flexible syntax can be
    combined.
    
    To do so, this pr makes these changes:
    - 1. support regex query both on index and raw data;
    - 2. translate the pattern matching to regex query, so that it can be
    handled by the regex query logic;
    - 3. loose the limit of the expression parsing, which allows general
    pattern matching syntax;
    
    With the support of regex query in segcore backend, we can also add
    mysql-like `REGEXP` syntax later easily.
    
    ---------
    
    Signed-off-by: longjiquan <[email protected]>
    longjiquan authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e549148 View commit details
    Browse the repository at this point in the history
  8. fix: call injectDone after compaction failed (milvus-io#30277)

    syncMgr.Block() will lock the segment when executing compaction.
    
    Previous implementation was unable to Unblock thoese segments when
    compaction failed. If next compaction of the same segments arrives,
    it'll stuck forever and block all later compation tasks.
    
    This PR makes sure compaction executor would Unblock these segments
    after a failure compaction.
    
    Apart form that, this PR also refines some logs and clean some codes of
    compaction, compactor:
    
    1. Log segment count instead of segmentIDs to avoid logging too many
    segments
    2. Flush RPC returns L1 segments only, skip L0 and L2
    3. CompactionType is checked in `Compaction`, no need to check again
    inside compactor
    4. Use ligter method to replace `getSegmentMeta`
    5. Log information for L0 compaction when encounters an error
    
    See also: milvus-io#30213
    
    ---------
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    fb5e09d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    32914a3 View commit details
    Browse the repository at this point in the history
  10. fix: Support mvcc with hybrid serach (milvus-io#30114)

    issue: milvus-io#29656
    /kind bug
    
    Signed-off-by: xige-16 <[email protected]>
    
    ---------
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    060c860 View commit details
    Browse the repository at this point in the history
  11. enhance: check load state before altering collection (milvus-io#30399)

    /kind improvement
    
    Signed-off-by: sunby <[email protected]>
    sunby authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e22e8b3 View commit details
    Browse the repository at this point in the history
  12. enhance: support varchar autoid when bulkinsert (milvus-io#30377)

    support varchar autoid when bulkinsert
    
    Signed-off-by: lixinguo <[email protected]>
    Co-authored-by: lixinguo <[email protected]>
    smellthemoon and lixinguo authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6bc10f9 View commit details
    Browse the repository at this point in the history
  13. enhance: roll back apimachinery to v0.28.6 (milvus-io#30398)

    apimachinery use go 1.21 in v0.29.0
    reference issue: golang/go#62409
    
    Signed-off-by: sunby <[email protected]>
    sunby authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    adaf270 View commit details
    Browse the repository at this point in the history
  14. fix: Limit L0 Compaction segment size and count (milvus-io#30374)

    See also: milvus-io#30191
    
    ---------
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e0ed564 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    1c1dd48 View commit details
    Browse the repository at this point in the history
  2. fix: Correct Size calculation of DeleteData (milvus-io#30397)

    This PR would correct the actual deltalog size
    
    See also: milvus-io#30191
    
    ---------
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d744962 View commit details
    Browse the repository at this point in the history
  3. enhance: update milvus-proto dep to add sparse vector related protos (m…

    …ilvus-io#30400)
    
    issue: milvus-io#29419
    
    this PR solely adds proto definition. sparse float vector support will
    be in subsequent PRs.
    
    Signed-off-by: Buqian Zheng <[email protected]>
    zhengbuqian authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1632668 View commit details
    Browse the repository at this point in the history
  4. fix: failed to download OpenDAL (milvus-io#30380)

    OpenDAL's url has been changed
    fix milvus-io#30379
    
    Signed-off-by: yah01 <[email protected]>
    yah01 authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ec688f5 View commit details
    Browse the repository at this point in the history
  5. enhance: Opt maxVectorFieldNum param check (milvus-io#30440)

    Signed-off-by: xige-16 <[email protected]>
    
    ---------
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6d70618 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3b58670 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dcdf859 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0a78b38 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    02de842 View commit details
    Browse the repository at this point in the history
  10. fix: fix hybrid search panic when has multi shard (milvus-io#30464)

    /kind bug
    issue:milvus-io#30457
    Signed-off-by: xige-16 <[email protected]>
    
    Signed-off-by: xige-16 <[email protected]>
    xige-16 authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    05ebe7b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e4a0338 View commit details
    Browse the repository at this point in the history
  12. Update all contributors

    Signed-off-by: sre-ci-robot <[email protected]>
    sre-ci-robot committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c7cf7c8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1ab851d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5cdf0f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Configuration menu
    Copy the full SHA
    36d3fd4 View commit details
    Browse the repository at this point in the history
  2. fix: Decoupling importing segment from flush process (milvus-io#30402)

    This pr decoups importing segment from flush process by:
    1. Exclude the importing segment from the flush policy, this approch
    avoids notifying the datanode to flush the importing segment, which may
    not exist.
    2. When RootCoord call Flush, DataCoord directly set the importing
    segment state to `Flushed`.
    
    issue: milvus-io#30359
    
    ---------
    
    Signed-off-by: bigsheeper <[email protected]>
    bigsheeper authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7ce876a View commit details
    Browse the repository at this point in the history
  3. [automated] Update Knowhere Commit (milvus-io#30487)

    Update Knowhere Commit
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    20c9cfc View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. fix: donot set l0 segment as growing when savebinlogs (milvus-io#29194)

    This PR fixes negative growing L0 segments in Metrics
    
    See also: milvus-io#29204, milvus-io#30441
    
    ---------
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    6959630 View commit details
    Browse the repository at this point in the history
  2. enhance: Speed up L0 compaction (milvus-io#30410)

    This PR changes the following to speed up L0 compaction and
    prevent OOM:
    
    1. Lower deltabuf limit to 16MB by default, so that each L0 segment
    would be 4X smaller than before.
    2. Add BatchProcess, use it if memory is sufficient
    3. Iterator will Deserialize when called HasNext to avoid massive memory
    peek
    4. Add tracing in spiltDelta
    
    See also: milvus-io#30191
    
    ---------
    
    Signed-off-by: yangxuan <[email protected]>
    XuanYang-cn authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    e6eb6f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5143b8c View commit details
    Browse the repository at this point in the history
  4. fix: not store timestampTo and timestampFrom (milvus-io#30450)

    milvus-io#30451
    
    Signed-off-by: lixinguo <[email protected]>
    Co-authored-by: lixinguo <[email protected]>
    smellthemoon and lixinguo authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    da50fbf View commit details
    Browse the repository at this point in the history
  5. enhance: access log method support get status when method only return…

    … error instead of status (milvus-io#30409)
    
    Signed-off-by: aoiasd <[email protected]>
    aoiasd authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    23aa136 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    18b979d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6e78cf2 View commit details
    Browse the repository at this point in the history
  8. enhance: [skip-e2e] disable asan (milvus-io#30498)

    fix: milvus-io#30511 
    /kind improvement
    
    ---------
    
    Signed-off-by: longjiquan <[email protected]>
    longjiquan authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a587450 View commit details
    Browse the repository at this point in the history
  9. [automated] Update Knowhere Commit (milvus-io#30515)

    Update Knowhere Commit
    Signed-off-by: sre-ci-robot [email protected]
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    sre-ci-robot and github-actions[bot] authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    ebbe32d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. fix: Verify sync task target segment and retry if not match (milvus-i…

    …o#30500)
    
    See also milvus-io#27675 milvus-io#30469
    
    For a sync task, the segment could be compacted during sync task. In
    previous implementation, this sync task will hold only the old segment
    id as KeyLock, in which case compaction on compacted to segment may run
    in parallel with delta sync of this sync task.
    
    This PR introduces sync target segment verification logic. It shall
    check target segment lock it's holding beforing actually syncing logic.
    If this check failed, sync task shall return`errTargetSegementNotMatch`
    error and make manager re-fetch the current target segment id.
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a68b321 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73f6ed6 View commit details
    Browse the repository at this point in the history
  3. enhance: decrease coordinator init time (milvus-io#29822)

    This PR mainly improve two items:
    1. Target observer should refresh loading status during init time. An
    uninitialized loading status blocks search/query. Currently, the target
    observer refreshes every 10 seconds, i.e. we'd need to wait for 10s for
    no reason. That's also the reason why we constantly see false log
    "collection unloaded" upon mixcoord restarts.
    2. Delete session when service is stopped. So that the new service
    doesn't need to wait for the previous session to expire (~10s).
    
    Item 1 is the major improvement of this PR, which should speed up init
    time by 10s.
    Item 2 is not a big concern in most cases as coordinators usually shut
    down after stop(). In those cases, coordinator restart triggers serverID
    change which further triggers an existing logic that deletes expired
    session. This PR only fixes rare cases where serverID doesn't change.
    
    integration test:
    `go test -tags dynamic -v -coverprofile=profile.out -covermode=atomic
    tests/integration/coordrecovery/coord_recovery_test.go -timeout=20m`
    Performance after the change:
    Average init time of coordinators: 10s
    Hardware: M2 Pro
    Test setup: 1000 collections with 1000 rows (dim=128) per collection.
    
    
    issue: milvus-io#29409
    
    Signed-off-by: yiwangdr <[email protected]>
    yiwangdr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    32cff25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e184c89 View commit details
    Browse the repository at this point in the history
  5. enhance: Add log when garbage collection resumed (milvus-io#30535)

    /kind enhancement
    
    Signed-off-by: wayblink <[email protected]>
    wayblink authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1635211 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5449e86 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    d097d55 View commit details
    Browse the repository at this point in the history
  2. enhance: disallow tikv/rawkv usages (milvus-io#30027)

    Data write through rawkv API may pollute tikv data. It should be
    disallowed.
    We will add this check to all repos that involves metadata access.
    In the longer term, we should have a metadata service that implements
    access control.
    
    relate: milvus-io#30029
    
    Signed-off-by: yiwangdr <[email protected]>
    yiwangdr authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    85246c1 View commit details
    Browse the repository at this point in the history
  3. test: removing deprecated code (milvus-io#30484)

    issue: milvus-io#29507
    Removing deprecated code from integration test lib
    
    Signed-off-by: yiwangdr <[email protected]>
    yiwangdr authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    98adbb3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d4100d5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a053715 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    92d1d74 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b111f3b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    715f042 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    5bbace1 View commit details
    Browse the repository at this point in the history
  2. fix: erase pk empty check when pk index replace raw data (milvus-io#3…

    …0432)
    
    milvus-io#30350
    
    Signed-off-by: luzhang <[email protected]>
    Co-authored-by: luzhang <[email protected]>
    zhagnlu and luzhang authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e8a6f1e View commit details
    Browse the repository at this point in the history
  3. feat: restful support new features (milvus-io#30485)

    feat: restful support new features
    
    1. search with groupingField milvus-io#25324
    2. hybrid search milvus-io#25639
    
    Signed-off-by: PowderLi <[email protected]>
    PowderLi authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1b87bcd View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Configuration menu
    Copy the full SHA
    bb93b22 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84566dc View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. enhance: remove unused code (milvus-io#30601)

    Signed-off-by: Alexandr Guzhva <[email protected]>
    alexanderguzhva authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a297baa View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. test: remove xfail for testcase (milvus-io#30622)

    issue has been fixed then remove xfail for testcase
    
    Signed-off-by: zhuwenxing <[email protected]>
    zhuwenxing authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    bb63e32 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91b02b5 View commit details
    Browse the repository at this point in the history
  3. fix: make compactor inject done called no more than once (milvus-io#3…

    …0603)
    
    See also milvus-io#30571
    
    When `compactionExecutor` stops one compaction task, the `stop` method
    will case `injectDone` called.
    
    However in `executeTask` when `compact` method returns error, it shall
    also invoke `injectDone` as well. That the reason `Unlock of unlocked
    RWMutex` panicking happened.
    
    This PR add sync.Once to make sure that `injectDone` is called only
    once. We did not remove any of the `injectDone` since removal any of
    those invocation may cause logic problem.
    
    ---------
    
    Signed-off-by: Congqi Xia <[email protected]>
    congqixia authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    3c2e037 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2bc212c View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. replace binlogIO with io.BinlogIO in datanode

    Signed-off-by: wayblink <[email protected]>
    wayblink committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    770aa6e View commit details
    Browse the repository at this point in the history