Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly build xcframework #124

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

okwasniewski
Copy link
Contributor

Hey,

This PR features multiple changes to fix how xcframeworks are handled.

Changes included:

  • Move from macos-latest-large to macos-latest for the CI (Only build-dawn.yml requires M1 machine for now)
  • Remove visionOS x86 build (building on Intel macs for visionOS is deprecated so lets not waste resources on this)
  • I aligned apple.toolchain.cmake with upstream source code.
  • Package only xcframeworks in build dawn job (currently the artifacts were over 450mbs because contained unnecessary stuff)

Changes to build scripts

So before we created a bunch of xcframeworks then linked them for each platform.

The whole idea behind xcframeworks is to have one bundle for multiple platforms(!).

Before (contents generated by build-dawn job):

CleanShot 2024-09-20 at 14 36 12@2x

Now:

CleanShot 2024-09-20 at 14 35 31@2x

@okwasniewski
Copy link
Contributor Author

cc: @Saadnajmi @wcandillon

@wcandillon
Copy link
Owner

Looks great thank you :) :)

@okwasniewski
Copy link
Contributor Author

Im not sure why this fails.. Probably we need to re-trigger build-dawn?

@okwasniewski
Copy link
Contributor Author

okwasniewski commented Sep 24, 2024

@wcandillon The build is green! I missed that I removed additional line from podspec (which is now back)!

@wcandillon
Copy link
Owner

thanks for pushing the fixes :)

@wcandillon wcandillon self-requested a review September 24, 2024 14:52
@wcandillon wcandillon merged commit 30a3ac8 into wcandillon:main Sep 24, 2024
5 checks passed
@okwasniewski okwasniewski deleted the fix/xcframework branch September 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants