Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This PR features multiple changes to fix how
xcframeworks
are handled.Changes included:
macos-latest-large
tomacos-latest
for the CI (Onlybuild-dawn.yml
requires M1 machine for now)apple.toolchain.cmake
with upstream source code.xcframeworks
in build dawn job (currently the artifacts were over 450mbs because contained unnecessary stuff)Changes to build scripts
So before we created a bunch of xcframeworks then linked them for each platform.
The whole idea behind xcframeworks is to have one bundle for multiple platforms(!).
Before (contents generated by build-dawn job):
Now: