[blocked] Record client disconnected errors as HTTP 499 #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leth
changed the title
|
Ah, it looks like this change requires a newer version of golang. |
This was referenced Apr 2, 2019
Merged
rndstr
force-pushed
the
http-499-client-disc
branch
from
52de3bc
to
4cc754c
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy nginx and use HTTP 499 to denote requests where the client went away.
I'm not 100% certain that the way I'm detecting this is bulletproof, but if I have read the docs right it should be correct.
NB this only covers HTTP proxying, not httpgrpc.